Fix: request groups for oidc #336
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samolego
changed the title
Contributor
|
We can't merge this change as it might/will break other idps. |
Author
|
May I know why? It sounds completely strange to me, why would you expect to get |
|
Not all IdPs silently ignore unknown scopes. Can you conditionally request a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I was frustrated to see that the desktop client doesn't support Authelia auth due to not requesting groups "permission". I added that, it's a tiny fix.
Fixes #217.
I have tested it with my local setup and seems to work fine.
Edit: if anyone wants to try, here's my workflow artifacts