-
Notifications
You must be signed in to change notification settings - Fork 9
chore: more repo maintenance #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR is focused on repository maintenance, including updating documentation and marking deprecated test files for removal.
- Removed an image table section from the README.
- Added a FIXME comment in a test file regarding its future deletion.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Removed outdated image table section from the documentation. |
| OpenCloudTests/Metadata/MetadataDocumentationTests.swift | Added a FIXME comment to indicate the file should be deleted. |
Files not reviewed (2)
- OpenCloud.xcodeproj/xcshareddata/xcschemes/OpenCloud.xcscheme: Language not supported
- tools/GenerateDocs/generate_docs.sh: Language not supported
| import OpenCloudSDK | ||
| import OpenCloudAppShared | ||
|
|
||
| // FIXME: delete all references to this file and then this file. |
Copilot
AI
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The FIXME comment is ambiguous about whether the file should be removed entirely or updated. Please clarify the intent or remove the file if it is no longer needed.
4075129 to
0fad33b
Compare
|
Looks OK i guess? |
0fad33b to
bd97559
Compare
Rebased, but last time CI was failing. Let's see what it says now |
Seems unrelated to this issue. Maybe something needs to be adjusted here: https://github.com/opencloud-eu/ios/blob/main/.github/workflows/build-and-analyze.yml#L25 |
Even more repo maintenance..