Skip to content

Conversation

@kulmann
Copy link
Contributor

@kulmann kulmann commented Apr 24, 2025

Even more repo maintenance..

@kulmann kulmann requested review from TheOneRing, Copilot and guruz April 24, 2025 14:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is focused on repository maintenance, including updating documentation and marking deprecated test files for removal.

  • Removed an image table section from the README.
  • Added a FIXME comment in a test file regarding its future deletion.

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
README.md Removed outdated image table section from the documentation.
OpenCloudTests/Metadata/MetadataDocumentationTests.swift Added a FIXME comment to indicate the file should be deleted.
Files not reviewed (2)
  • OpenCloud.xcodeproj/xcshareddata/xcschemes/OpenCloud.xcscheme: Language not supported
  • tools/GenerateDocs/generate_docs.sh: Language not supported

import OpenCloudSDK
import OpenCloudAppShared

// FIXME: delete all references to this file and then this file.
Copy link

Copilot AI Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The FIXME comment is ambiguous about whether the file should be removed entirely or updated. Please clarify the intent or remove the file if it is no longer needed.

Copilot uses AI. Check for mistakes.
@kulmann kulmann force-pushed the repo-maintenance-2 branch from 4075129 to 0fad33b Compare April 24, 2025 14:26
@guruz
Copy link
Collaborator

guruz commented Aug 21, 2025

Looks OK i guess?
rebase+merge?

@kulmann kulmann force-pushed the repo-maintenance-2 branch from 0fad33b to bd97559 Compare August 21, 2025 14:27
@kulmann
Copy link
Contributor Author

kulmann commented Aug 21, 2025

Looks OK i guess? rebase+merge?

Rebased, but last time CI was failing. Let's see what it says now

@guruz
Copy link
Collaborator

guruz commented Aug 21, 2025

Error: Device not found (platform: iOS, version: >=18.2.0 <18.3.0-0)

Error: Error: Create Artifact Container failed: The artifact name build#16.0azeaw.xcresult is not valid. Request URL https://pipelinesghubeus26.actions.githubusercontent.com/nUeXN9dTsFHNQ8ixPaE02z22TNZcu5Sd5HX9rJuRpgrNe5ftq0/_apis/pipelines/workflows/17129918463/artifacts?api-version=6.0-preview

Seems unrelated to this issue.

Maybe something needs to be adjusted here: https://github.com/opencloud-eu/ios/blob/main/.github/workflows/build-and-analyze.yml#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants