Add clarification as to error handling with gNMI extensions. #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
robshakir
commented
Apr 7, 2025
robshakir
commented
* (M) rpc/gnmi/gnmi-extensions.md
- Add clarification that unknown extensions must not be treated
as an error.
- Add clarification that known extensions that are invalid may
be treated as an error.
|
Lgtm. Thanks. |
dplore
reviewed
Apr 7, 2025
Member
There was a problem hiding this comment.
Content LGTM.
Also update the revision date and version?
Should we also update to the gnmi spec and gnmi_ext.proto?
Member
Author
There was a problem hiding this comment.
Updated revision date + version.
What do you propose we update in the gNMI spec + proto? Part of the reasons for the modularity of specs we have is to prevent there being a single doc that is somewhat unmaintainable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.