Skip to content

Conversation

@loveleif
Copy link
Collaborator

No description provided.

@loveleif loveleif mentioned this pull request Nov 23, 2025
@loveleif loveleif marked this pull request as ready for review November 24, 2025 08:00
Copy link
Collaborator

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that you renamed the base class to something not ending in Test. I very much prefer that too.

}
}

object TreeNodeTest {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can't be inner classes of the test class anymore because it mess up some of the tree node magic now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid, I never liked sprinkling inner classes just for sport.

@loveleif loveleif merged commit d719043 into opencypher:master Nov 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants