build: New quarterly check to update the Slack invite#1540
Conversation
|
@brian-smith-tcril could you review? @arbrandes heads up that if this merges this week, this check OUGHT to generate a ticket on September 1st, but it's a noop as I've already done the task for this quarter. |
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Overall this looks good!
One small thing about YAML/cron syntax.
I also see you have this set to be able to run using workflow_dispatch - is that something you've already tested?
| name: Create quarterly issues for Repo Checks audit | ||
| on: | ||
| schedule: | ||
| - cron: 0 0 1 3,6,9,12 * |
There was a problem hiding this comment.
I checked the docs https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax?s=09#onschedule and found
# * is a special character in YAML so you have to quote this string
There was a problem hiding this comment.
I just copied https://github.com/openedx/axim-engineering/blob/main/.github/workflows/add-quarterly-GH-audit.yml#L2-L5 which seems to work fine... 🤷🏻♀️
There was a problem hiding this comment.
Very odd... GH workflow docs never seem to make the most sense.
There was a problem hiding this comment.
I added it in anyway, if it works for the Sep 1 run I'll add it to the other workflows.
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Considering this is pretty much identical to https://github.com/openedx/axim-engineering/blob/main/.github/workflows/add-quarterly-GH-audit.yml, I'm going to approve this even if it hasn't been tested by doing a manual workflow dispatch.
2 participants
No description provided.