Skip to content

fix: do not update LMS user during retirement #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Agrendalath wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not update LMS user during retirement #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@ Unreleased

*

0.3.8 - 2025-10-21
******************

Fixed
-----

* Do not modify LMS users during retirement — this is handled by the LMS retirement pipeline.

0.3.4 – 2025-08-13
******************

Expand Down
2 changes: 1 addition & 1 deletion forum/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
Openedx forum app.
"""

__version__ = "0.3.7"
__version__ = "0.3.8"
15 changes: 6 additions & 9 deletions forum/api/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import math
from typing import Any, Optional

from forum.backend import get_backend
from forum.backend import get_backend, is_mysql_backend_enabled
from forum.constants import FORUM_DEFAULT_PAGE, FORUM_DEFAULT_PER_PAGE
from forum.serializers.thread import ThreadSerializer
from forum.serializers.users import UserSerializer
Expand Down Expand Up @@ -135,14 +135,11 @@ def retire_user(
user = backend.get_user(user_id)
if not user:
raise ForumV2RequestError(f"user not found with id: {user_id}")
backend.update_user(
user_id,
data={
"email": "",
"username": retired_username,
"read_states": [],
},
)
data: dict[str, Any] = {"read_states": []}
if not is_mysql_backend_enabled(course_id):
data["username"] = retired_username
data["email"] = ""
backend.update_user(user_id, data=data)
backend.unsubscribe_all(user_id)
backend.retire_all_content(user_id, retired_username)

Expand Down