Skip to content

fix(deps): regenerate package-lock.json#1855

Open
brian-smith-tcril wants to merge 7 commits intoopenedx:masterfrom
brian-smith-tcril:brian-smith-tcril/regenerate-package-lock
Open

fix(deps): regenerate package-lock.json#1855
brian-smith-tcril wants to merge 7 commits intoopenedx:masterfrom
brian-smith-tcril:brian-smith-tcril/regenerate-package-lock

Conversation

@brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Feb 2, 2026

Regenerating the lockfile to pick up latest compatible @edx/frontend-component-footer (14.9.5).

What I ran to regenerate the lockfile:

rm -rf node_modules/
rm package-lock.json
nvm use
npm install

Additional fixes

1. Move @openedx/frontend-build to devDependencies

frontend-build was incorrectly in dependencies instead of devDependencies.

2. Remove direct jest devDependency

The direct jest devDependency was causing ts-jest to be nested under frontend-build instead of hoisted to the top level, breaking module resolution.

3. Fix Jest mock hoisting for MockedPluginSlot

Jest hoists jest.mock() calls to the top of the file, which caused MockedPluginSlot to be undefined when the mock factory executed. Changed to use require() inside the factory so it loads at runtime.

4. Handle nullable breakpoint types

Paragon's breakpoint types now have optional minWidth/maxWidth properties (openedx/paragon#3524). Added non-null assertions since these values are always defined in practice.

5. Add IntlProvider to ContentIFrame tests

Paragon's ModalDialog now uses useIntl() (openedx/paragon#3624), requiring an IntlProvider wrapper in tests that render modals.

6. Await async operations in Course tests

Fixed dangling waitFor blocks that weren't awaited, causing tests to not actually wait for async operations. Changed to properly use await with screen.findBy*() queries.

7. Use dynamic imports in LearnerToolsSlot tests

Jest hoists mock calls but ES imports run before the test body. Using dynamic imports in beforeEach ensures mocks are set up before modules are loaded.

Note

Codecov reports a coverage decrease in GenericTourFormattedMessages.jsx, but this file was not modified in this PR. This is a pre-existing coverage gap (the file has no tests), not a regression caused by these changes.


This PR was created by Claude Code. See the plan for details.

brian-smith-tcril and others added 4 commits February 2, 2026 11:38
Co-Authored-By: Claude Code <noreply@anthropic.com>
Moved @openedx/frontend-build from dependencies to devDependencies.
Removed direct jest devDependency which was causing ts-jest hoisting issues.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Jest hoists jest.mock() calls to the top of the file, which caused
MockedPluginSlot to be undefined when the mock factory executed.
Using require() inside the factory ensures it loads at runtime.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Paragon's breakpoint types now have optional minWidth/maxWidth properties.
Added non-null assertions since these values are always defined in practice.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@brian-smith-tcril brian-smith-tcril force-pushed the brian-smith-tcril/regenerate-package-lock branch 3 times, most recently from 2ccbc33 to d743d43 Compare February 4, 2026 00:17
brian-smith-tcril and others added 3 commits February 3, 2026 19:23
Paragon's ModalDialog now uses useIntl() (openedx/paragon#3624),
requiring an IntlProvider in the component ancestry.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixed dangling waitFor blocks that weren't awaited, causing tests
to not actually wait for async operations. Changed to properly use
await with screen.findBy*() queries.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Jest hoists mock calls but ES imports run before the test body.
Using dynamic imports in beforeEach ensures mocks are set up
before modules are loaded.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@brian-smith-tcril brian-smith-tcril force-pushed the brian-smith-tcril/regenerate-package-lock branch from 979476b to 960b9bc Compare February 4, 2026 00:23
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.13%. Comparing base (630e843) to head (960b9bc).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1855      +/-   ##
==========================================
- Coverage   91.18%   91.13%   -0.06%     
==========================================
  Files         349      349              
  Lines        5831     5807      -24     
  Branches     1376     1335      -41     
==========================================
- Hits         5317     5292      -25     
- Misses        497      498       +1     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant