fix(deps): regenerate package-lock.json#1855
Open
brian-smith-tcril wants to merge 7 commits intoopenedx:masterfrom
Open
fix(deps): regenerate package-lock.json#1855brian-smith-tcril wants to merge 7 commits intoopenedx:masterfrom
brian-smith-tcril wants to merge 7 commits intoopenedx:masterfrom
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
Moved @openedx/frontend-build from dependencies to devDependencies. Removed direct jest devDependency which was causing ts-jest hoisting issues. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Jest hoists jest.mock() calls to the top of the file, which caused MockedPluginSlot to be undefined when the mock factory executed. Using require() inside the factory ensures it loads at runtime. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Paragon's breakpoint types now have optional minWidth/maxWidth properties. Added non-null assertions since these values are always defined in practice. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2ccbc33 to
d743d43
Compare
Paragon's ModalDialog now uses useIntl() (openedx/paragon#3624), requiring an IntlProvider in the component ancestry. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixed dangling waitFor blocks that weren't awaited, causing tests to not actually wait for async operations. Changed to properly use await with screen.findBy*() queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Jest hoists mock calls but ES imports run before the test body. Using dynamic imports in beforeEach ensures mocks are set up before modules are loaded. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
979476b to
960b9bc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
- Coverage 91.18% 91.13% -0.06%
==========================================
Files 349 349
Lines 5831 5807 -24
Branches 1376 1335 -41
==========================================
- Hits 5317 5292 -25
- Misses 497 498 +1
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerating the lockfile to pick up latest compatible
@edx/frontend-component-footer(14.9.5).What I ran to regenerate the lockfile:
Additional fixes
1. Move
@openedx/frontend-buildto devDependenciesfrontend-build was incorrectly in dependencies instead of devDependencies.
2. Remove direct jest devDependency
The direct jest devDependency was causing ts-jest to be nested under frontend-build instead of hoisted to the top level, breaking module resolution.
3. Fix Jest mock hoisting for MockedPluginSlot
Jest hoists
jest.mock()calls to the top of the file, which causedMockedPluginSlotto be undefined when the mock factory executed. Changed to userequire()inside the factory so it loads at runtime.4. Handle nullable breakpoint types
Paragon's breakpoint types now have optional
minWidth/maxWidthproperties (openedx/paragon#3524). Added non-null assertions since these values are always defined in practice.5. Add IntlProvider to ContentIFrame tests
Paragon's ModalDialog now uses
useIntl()(openedx/paragon#3624), requiring an IntlProvider wrapper in tests that render modals.6. Await async operations in Course tests
Fixed dangling
waitForblocks that weren't awaited, causing tests to not actually wait for async operations. Changed to properly useawaitwithscreen.findBy*()queries.7. Use dynamic imports in LearnerToolsSlot tests
Jest hoists mock calls but ES imports run before the test body. Using dynamic imports in
beforeEachensures mocks are set up before modules are loaded.Note
Codecov reports a coverage decrease in
GenericTourFormattedMessages.jsx, but this file was not modified in this PR. This is a pre-existing coverage gap (the file has no tests), not a regression caused by these changes.This PR was created by Claude Code. See the plan for details.