fix: make some of this app work in tutor#381
Draft
kdmccormick wants to merge 2 commits intoopenedx:masterfrom
Draft
fix: make some of this app work in tutor#381kdmccormick wants to merge 2 commits intoopenedx:masterfrom
kdmccormick wants to merge 2 commits intoopenedx:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 88.35% 88.34% -0.02%
==========================================
Files 164 164
Lines 3462 3459 -3
Branches 856 856
==========================================
- Hits 3059 3056 -3
Misses 399 399
Partials 4 4 ☔ View full report in Codecov by Sentry. |
|
Sandbox deployment successful 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sandbox at: https://app.pr-381-98a602.sandboxes.opencraft.hosting/support-tools/learner_information/?username=openedx
Description
This makes most of the support-tools pages render when running in Tutor. The main problem was that
getConfig()was being run at init-time instead of runtime, so the MFE was using values from the .env files instead of from the MFE Config API.Running in Tutor
This just requires enabling tutor-mfe plus a simple custom plugin:
Open issues
/) instead of a subpath (/support-tools). We have fixed this problem in several MFEs and it could be fixed here too.Status
This was mostly for my own reference. I don't plan on trying to merge this unless it becomes clear that we want to keep this MFE in the openedx org.
Some screenshots of pages that do work