Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
- Coverage 76.31% 75.74% -0.57%
==========================================
Files 33 31 -2
Lines 591 569 -22
Branches 137 131 -6
==========================================
- Hits 451 431 -20
+ Misses 126 124 -2
Partials 14 14
Continue to review full report at Codecov.
|
sameenfatima78
approved these changes
Apr 12, 2022
Member
sameenfatima78
left a comment
There was a problem hiding this comment.
Looks good... just one concern: Can't we just set the flag to true instead of removing it?
zamanafzal
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge checklist:
frontend-app-learner-portal-enterprise,frontend-app-admin-portal, andfrontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?BREAKING CHANGEso the NPM package is released as such.Post merge:
chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.Publish from package.jsonGithub Action workflow to publish these new package versions to NPM.masterbranch.npm view <package_name> versions --json).