fix: resolve styles issues for search submit button#4048
fix: resolve styles issues for search submit button#4048filippovskii09 wants to merge 10 commits intoopenedx:release-23.xfrom
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @filippovskii09! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
❌ Deploy Preview for paragon-openedx-v23 failed. Why did it fail? →Built without sensitive environment variables
|
src/SearchField/index.scss
Outdated
| &:focus { | ||
| &::before { | ||
| border-radius: 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
| &:focus { | |
| &::before { | |
| border-radius: 0; | |
| } | |
| } | |
| &:focus::before { | |
| border-radius: 0; | |
| } |
src/SearchField/index.scss
Outdated
| &:focus-visible { | ||
| &::after { | ||
| content: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
| &:focus-visible { | |
| &::after { | |
| content: none; | |
| } | |
| } | |
| &:focus-visible::after { | |
| content: none; | |
| } |
There was a problem hiding this comment.
Why do we have so many changes in this file?
tsconfig.json
Outdated
| "allowJs": false, | ||
| "outDir": "dist" | ||
| "outDir": "dist", | ||
| "skipLibCheck": true |
There was a problem hiding this comment.
Do we need this changes?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4048 +/- ##
=============================================
Coverage 94.39% 94.39%
=============================================
Files 242 242
Lines 4296 4303 +7
Branches 1013 1025 +12
=============================================
+ Hits 4055 4062 +7
- Misses 233 237 +4
+ Partials 8 4 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o filippovskii/fix/fix-styles-for-search-submit
github-project-automation
bot
moved this from Waiting on Author
to Done
in Contributions
|
Reopen in this PR #4083 |
3 participants
Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?Post-merge Checklist