add pre-final specifications note and update references #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2bo
requested review from
GarethCOliver,
Sakurann,
awoie,
bc-pi,
danielfett,
hlozi,
jogu,
paulbastian and
tlodderstedt
and removed request for
Sakurann
jogu
approved these changes
Dec 23, 2025
Contributor
There was a problem hiding this comment.
One typo, otherwise looks good to me, thanks Christian!
Also I agree that it's fine not to mention the fully specified algs (because there's no breaking change since the version mentioned in VCI) & attestation best client auth (where there is no new version) is fine, there's no need to repeat things already said in VCI when we're happy with what VCI said.
Co-authored-by: Joseph Heenan <joseph@authlete.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only added specifications that are directly referenced in HAIP.
VCI & VP also reference (normatively):
I think it's fine not mentioning those?