Skip to content

Conversation

@rkennke
Copy link

@rkennke rkennke commented Nov 19, 2025

This change initializes the event configurations (known as event handlers in earlier JDKs) early, in order to avoid potential deadlocks (see description in the issue).

JDK 21 is the last JDK where this is relevant, that code has been completely reworked in JDK 22 (e.g. JDK-8319374).

Testing:

  • jdk/jfr
  • tier1

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8371889 needs maintainer approval

Issue

  • JDK-8371889: JFR: Deadlock in ThrowableTracer (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2483/head:pull/2483
$ git checkout pull/2483

Update a local copy of the PR:
$ git checkout pull/2483
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2483

View PR using the GUI difftool:
$ git pr show -t 2483

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2483.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2025

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@rkennke rkennke marked this pull request as ready for review November 20, 2025 12:16
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2025
@rkennke rkennke changed the title 8371889: Deadlock in ThrowableTracer 8371889: JFR: Deadlock in ThrowableTracer Nov 20, 2025
@rkennke
Copy link
Author

rkennke commented Nov 20, 2025

/label add hotspot-jfr

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@rkennke
The label hotspot-jfr is not a valid label.
These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Nov 20, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2025

@rkennke This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants