-
Notifications
You must be signed in to change notification settings - Fork 150
8244336: Restrict algorithms at JCE layer #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
phohensee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super trivial: in Signature.java, missing blank line before line 254. Also, testing?
|
Hi @phohensee For testing, see also the fix request comment in the JBS issue. |
|
Hi @phohensee |
I backport this for parity with 21.0.11-oracle.
I had to resolve a few files, mostly due to the removal of the
security manager:
src/java.base/share/classes/java/security/Signature.java
Adapted patch in getInstance(String) to slightly different coding.
src/java.base/share/classes/sun/security/util/AbstractAlgorithmConstraints.java
Copyright.
getAlgorithms(String): Needed to adapt to security coding.
src/java.base/share/classes/sun/security/util/KnownOIDs.java
Resolved line 188 due to context difference.
Also, I had to adapt one test to work with the SM. See second commit.
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2519/head:pull/2519$ git checkout pull/2519Update a local copy of the PR:
$ git checkout pull/2519$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2519/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2519View PR using the GUI difftool:
$ git pr show -t 2519Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2519.diff
Using Webrev
Link to Webrev Comment