Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 15, 2025

I backport this for parity with 21.0.11-oracle.

I had to resolve a few files, mostly due to the removal of the
security manager:

src/java.base/share/classes/java/security/Signature.java
Adapted patch in getInstance(String) to slightly different coding.

src/java.base/share/classes/sun/security/util/AbstractAlgorithmConstraints.java
Copyright.
getAlgorithms(String): Needed to adapt to security coding.

src/java.base/share/classes/sun/security/util/KnownOIDs.java
Resolved line 188 due to context difference.

Also, I had to adapt one test to work with the SM. See second commit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8244336 needs maintainer approval
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8372102 to be approved

Issues

  • JDK-8244336: Restrict algorithms at JCE layer (Enhancement - P3)
  • JDK-8372102: Restrict algorithms at JCE layer (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2519/head:pull/2519
$ git checkout pull/2519

Update a local copy of the PR:
$ git checkout pull/2519
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2519/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2519

View PR using the GUI difftool:
$ git pr show -t 2519

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2519.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 35dabb1a5f31d985f00de21badeeedb026a63b94 8244336: Restrict algorithms at JCE layer Dec 15, 2025
@openjdk
Copy link

openjdk bot commented Dec 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Dec 15, 2025
@GoeLin GoeLin marked this pull request as ready for review December 16, 2025 08:23
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2025

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super trivial: in Signature.java, missing blank line before line 254. Also, testing?

@GoeLin
Copy link
Member Author

GoeLin commented Dec 17, 2025

Hi @phohensee
thanks for the review!
I added the blank line.

For testing, see also the fix request comment in the JBS issue.
The tests modified by this change pass.
Our nightly testing passed, including tier1-4 headless, jck, some bencharks. Some of the suites with -Xcomp.
win x86, linux aarch,ppc,x86,alpine, mac aarch,x86, aix.

@GoeLin
Copy link
Member Author

GoeLin commented Dec 19, 2025

Hi @phohensee
Could you please have a second look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants