8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server"

[sxa]

Backport of openjdk/jdk11u-dev#1377
Eclipse Temurin has seen this failure on some systems and this backport resolves them.

Sample failure when trying 100 iterations: https://ci.adoptium.net/job/Grinder/15544/testReport/ (82/100 failed)
Sample pass with this branch: https://ci.adoptium.net/job/Grinder/15551/testReport (zero failures)

Ref: https://bugs.openjdk.org/browse/JDK-8285836

Testing tier 1:

• Linux/x64 ✅
• Linux/aarch64 ✅
• Windows/x64
• Mac/x64 ✅
• AIX

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8285836 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server" (Bug - P3 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/721/head:pull/721
$ git checkout pull/721

Update a local copy of the PR:
$ git checkout pull/721
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/721/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 721

View PR using the GUI difftool:
$ git pr show -t 721

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/721.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sxa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sxa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server"

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• aa9168c: 8364660: ClassVerifier::ends_in_athrow() should be removed
• d2a1af6: 8313770: jdk/internal/platform/docker/TestSystemMetrics.java fails on Ubuntu
• e00c683: 8372660: [8u] ProblemList TestCPUAwareness until 8370492 is addressed
• ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/335fce5950cdb8f5e2227019ad3a908432654211...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (bfbfb3ed)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[sxa]

runtime/containers/docker/TestCPUAwareness.java failure in the Pre-submit tests - Linux x64 - Test (tier1) (and the 32-bit version) in GHA are failing on other PRs so is not related to this change and can therefore be ignored.

[jmtd]

I am not a Reviewer in jdk8u but to gain experience of doing so I've reviewed this change.

The PR is not labelled "clean" but I'm not sure why, the patch is identical to that in 11u and applies with no fuzz.

As @sxa notes the pre-submit failure is an issue in the main 8u tree at the moment and is not specific to this change.

Test-only change. I've run it and it passes for me after this patch, although I haven't done a battery of runs to aggregate the results, like the backporter has.

[jerboaa]

runtime/containers/docker/TestCPUAwareness.java failure

That is https://bugs.openjdk.org/browse/JDK-8370492 and a combination that --cpu-shares=1023 back-mapping to the default 100 with the new mapping function. So a value of --cpu-shares=1000 (mapping to 99) should be chosen for the test.

[jerboaa]

The PR is not labelled "clean" but I'm not sure why, the patch is identical to that in 11u and applies with no fuzz.

Path in JDK 11 is test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java. JDK 8 path is jdk/test/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java. I.e. test/jdk vs. jdk/test.

[jmtd]

Path in JDK 11 is test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java. JDK 8 path is jdk/test/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java. I.e. test/jdk vs. jdk/test.

Thanks... I had to read your comment twice to see the difference!

[sxa]

Is there anything else I need to do because it's not considered clean, or is that up to the reviewers?

[jerboaa]

Looks good. Clean after path unshuffeling.

[sxa]

/approval request test-only backport, clean after path unshuffling, tests pass

[openjdk]

@sxa
8285836: The approval request has been created successfully.

[bridgekeeper]

@sxa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

I've approved this test fix now. Once it gets the ready label, please integrate.

[openjdk]

⚠️ @sxa the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout keepalive-jdk8u
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push