Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 10, 2025

Hi all,

This backport PR will fix the test bug which cause sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java intermittent fails. Before this backport , test fails about 1/50 probability. After this backport PR, test run all passed 10k times.

This test was problemlist by JDK-8174855, this do not backported to jdk8u. So this backport do not need change the jdk/test/Problemlist.txt. And the copyright year different. These two parts cause this backport PR uncleanly. Other parts are all cleanly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8174734 needs maintainer approval

Issue

  • JDK-8174734: Safepoint sync time did not increase (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/734/head:pull/734
$ git checkout pull/734

Update a local copy of the PR:
$ git checkout pull/734
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/734/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 734

View PR using the GUI difftool:
$ git pr show -t 734

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/734.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c83db6b4d13ef015aed654311c10b87e570ac483 8174734: Safepoint sync time did not increase Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 10, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2025

Webrevs

@sendaoYan
Copy link
Member Author

GHA report linux-x64 and linux-x86 runtime/containers/docker/TestCPUAwareness.java fails, which is being exclude by #727, it's unrelated to this backport PR.

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

Thanks for the reviews @phohensee

/approval request Backport to fix the test bug which cause sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java intermittent fails. Before this backport PR, test fails about 1/50 probability. After this backport PR, test run all passed 10k times. Change has been verified locally on linux-x64, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@sendaoYan
8174734: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants