-
Notifications
You must be signed in to change notification settings - Fork 172
8174734: Safepoint sync time did not increase #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
GHA report linux-x64 and linux-x86 runtime/containers/docker/TestCPUAwareness.java fails, which is being exclude by #727, it's unrelated to this backport PR. |
|
|
|
Thanks for the reviews @phohensee /approval request Backport to fix the test bug which cause sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java intermittent fails. Before this backport PR, test fails about 1/50 probability. After this backport PR, test run all passed 10k times. Change has been verified locally on linux-x64, test-fix only, no risk. |
|
@sendaoYan |
Hi all,
This backport PR will fix the test bug which cause sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java intermittent fails. Before this backport , test fails about 1/50 probability. After this backport PR, test run all passed 10k times.
This test was problemlist by JDK-8174855, this do not backported to jdk8u. So this backport do not need change the jdk/test/Problemlist.txt. And the copyright year different. These two parts cause this backport PR uncleanly. Other parts are all cleanly.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/734/head:pull/734$ git checkout pull/734Update a local copy of the PR:
$ git checkout pull/734$ git pull https://git.openjdk.org/jdk8u-dev.git pull/734/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 734View PR using the GUI difftool:
$ git pr show -t 734Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/734.diff
Using Webrev
Link to Webrev Comment