Skip to content

Conversation

@vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Dec 12, 2025

update methods in java.lang.runtime.ArrayCreation, change the arguments with type RuntimeType to java.lang.Class


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8373620: [lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1796/head:pull/1796
$ git checkout pull/1796

Update a local copy of the PR:
$ git checkout pull/1796
$ git pull https://git.openjdk.org/valhalla.git pull/1796/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1796

View PR using the GUI difftool:
$ git pr show -t 1796

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1796.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2025

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lw5 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373620: [lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 284 new commits pushed to the lw5 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lw5 branch, type /integrate in a new comment.

@vicente-romero-oracle
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@vicente-romero-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.

@vicente-romero-oracle vicente-romero-oracle changed the title 8373620: [lw5] Change in java.lang.runtime.ArrayCreation API from RuntimeType to Class 8373620: [lw5] Substitute RuntimeType for Class in j.l.runtime.ArrayCreation Dec 12, 2025
@vicente-romero-oracle vicente-romero-oracle changed the title 8373620: [lw5] Substitute RuntimeType for Class in j.l.runtime.ArrayCreation 8373620: [lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation Dec 12, 2025
@vicente-romero-oracle
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@vicente-romero-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

⚠️ @vicente-romero-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@vicente-romero-oracle
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@vicente-romero-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.

@vicente-romero-oracle vicente-romero-oracle changed the title 8373620: [lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation 8373620: [lworld][lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation Dec 15, 2025
@vicente-romero-oracle
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Dec 15, 2025

@vicente-romero-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.

@vicente-romero-oracle vicente-romero-oracle changed the title 8373620: [lworld][lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation 8373620: [lworld] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation Dec 15, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2025
@vicente-romero-oracle
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Dec 15, 2025

@vicente-romero-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.

@mlbridge
Copy link

mlbridge bot commented Dec 15, 2025

Webrevs

@vicente-romero-oracle vicente-romero-oracle changed the title 8373620: [lworld] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation 8373620: [lworld] [lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation Dec 15, 2025
@vicente-romero-oracle
Copy link
Contributor Author

\touch

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you have other ways to pass the flags later.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2025
@MrSimms
Copy link
Member

MrSimms commented Dec 16, 2025

@vicente-romero-oracle did the "Commit message must refer to an issue" failure clear after reviewing or when ?

@vicente-romero-oracle vicente-romero-oracle changed the title 8373620: [lworld] [lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation 8373620: [lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants