-
Notifications
You must be signed in to change notification settings - Fork 137
8373620: [lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lw5
Are you sure you want to change the base?
8373620: [lw5] Substitute params with type j.l.r.RuntimeType by j.l.Class in j.l.runtime.ArrayCreation #1796
Conversation
…timeType to Class
|
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
|
@vicente-romero-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 284 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/touch |
|
@vicente-romero-oracle The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/touch |
|
@vicente-romero-oracle The pull request is being re-evaluated and the inactivity timeout has been reset. |
…lass in j.l.runtime.ArrayCreation
|
|
|
/touch |
|
@vicente-romero-oracle The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/touch |
|
@vicente-romero-oracle The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/touch |
|
@vicente-romero-oracle The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
\touch |
liach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you have other ways to pass the flags later.
|
@vicente-romero-oracle did the "Commit message must refer to an issue" failure clear after reviewing or when ? |
update methods in java.lang.runtime.ArrayCreation, change the arguments with type RuntimeType to java.lang.Class
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1796/head:pull/1796$ git checkout pull/1796Update a local copy of the PR:
$ git checkout pull/1796$ git pull https://git.openjdk.org/valhalla.git pull/1796/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1796View PR using the GUI difftool:
$ git pr show -t 1796Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1796.diff
Using Webrev
Link to Webrev Comment