Skip to content

Conversation

@david-beaumont
Copy link
Contributor

@david-beaumont david-beaumont commented Dec 20, 2025

Preview mode support for exploded build.

This is an alternate approach from #1845 which I think is actually cleaner and more robust.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8373987: [lworld] exploded-image/test broken since disable patching (JDK-8373806) (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1854/head:pull/1854
$ git checkout pull/1854

Update a local copy of the PR:
$ git checkout pull/1854
$ git pull https://git.openjdk.org/valhalla.git pull/1854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1854

View PR using the GUI difftool:
$ git pr show -t 1854

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1854.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2025

👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 20, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant