This repository was archived by the owner on May 2, 2019. It is now read-only.
Download compiler and library using HTTPS#397
Open
thanatos wants to merge 1 commit intoopenlayers:masterfrom
Open
Download compiler and library using HTTPS#397thanatos wants to merge 1 commit intoopenlayers:masterfrom
thanatos wants to merge 1 commit intoopenlayers:masterfrom
Conversation
This reverts commit fb3f4b0. That commit changed the download of the compiler and library to be done over plain, unencrypted HTTP. This caused a Node Security Advisory[1], which states: Affected versions of closure-util insecurely download an executable over an unencrypted HTTP connection. In scenarios where an attacker has a privileged network position, it is possible to intercept the response and replace the executable with a malicious one, resulting in code execution on the system running closure-util. The original change from HTTPS to HTTP was done due to some users reporting that their corporate networks were blocking or failing to download over HTTPS. While this is unfortunate, trading the security of every user of openlayers for a few users with poorly configured networks is not a good balance. This reverts the commit, to ensure that it is not possible for an attacker to compromise the machine downloading OpenLayers for the majority of users. For those few who need it, it is still possible to fork this repository and apply the patch to use HTTP, as ill-advised as that would be. It is also possible for them to pin to the version of OpenLayers that contains the above vulnerability. [1]: https://nodesecurity.io/advisories/165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fb3f4b0.
That commit changed the download of the compiler and library to be done over plain, unencrypted HTTP.
This caused a Node Security Advisory, which states:
The original change from HTTPS to HTTP was done due to some users reporting that their corporate networks were blocking or failing to download over HTTPS. While this is unfortunate, trading the security of every user of openlayers for a few users with poorly configured networks is not a good balance. This reverts the commit, to ensure that it is not possible for an attacker to compromise the
machine downloading OpenLayers for the majority of users.
For those few who need it, it is still possible to fork this repository and apply the patch to use HTTP, as ill-advised as that would be. It is also possible for them to pin to the version of OpenLayers that contains the above vulnerability.