Open
Conversation
ajrbyers
approved these changes
Sep 30, 2025
Member
ajrbyers
left a comment
ajrbyers
left a comment
There was a problem hiding this comment.
I don't anticipate any of the changes I've requested to the parent PR affecting this PR so I'm going to approve it.
mauromsl
requested changes
Nov 6, 2025
Comment on lines
+134
to
+137
| api_url = plugin_settings.DATACITE_API_URL | ||
| if hasattr(article.journal, "status"): | ||
| if article.journal.status == Journal.PublishingStatus.TEST: | ||
| api_url = plugin_settings.DATACITE_API_TEST_URL |
Member
There was a problem hiding this comment.
Since this overrides the behaviour of the settings, I think we should put a warning on the template as well, to inform the user ("journal in test mode: Will use Datacite test API) type deal.
Member
Author
|
Going to wait until we figure out a solution for openlibhums/janeway#4988, and then make a template addition here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes openlibhums/janeway#4988.