Skip to content

Make sure artwork does not appear behind text#456

Open
joemull wants to merge 1 commit intomainfrom
b-242-text-background-a11y
Open

Make sure artwork does not appear behind text#456
joemull wants to merge 1 commit intomainfrom
b-242-text-background-a11y

Conversation

@joemull
Copy link
Member

@joemull joemull commented Feb 2, 2026

Fixes #242.

The strategy here is to create mostly invisible backgrounds that have the effect of erasing artwork that rolls behind text.

I went through all the custom templates to check for cases where this can happen and made changes. Here are some examples:

Screenshot from 2026-02-02 13-11-41 Screenshot from 2026-02-02 13-15-34 Screenshot from 2026-02-02 13-14-50 Screenshot from 2026-02-02 13-13-18 Screenshot from 2026-02-02 13-12-54

Copy link
Member

@StephDriver StephDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing and Observations

This looks great. I particularly like the naming of the classes using clock points.

  • I can't find anything using pointing-8-oclock I assume that is there for completeness?

Otherwise I've reviewed one of each of the class examples.

  • I am unsure about the use of pointing-10-oclock on the olh-award template - this looks odd with the triangle being parallel along one edge and almost but not along the other. For me this is jarring.
Image
  • Similarly, I am unsure about the angle used on the News page:
    Great at this size:
Image

But this is the 100% zoom version:

Image

Contrast that with the Internships page, where the angle of the background works well at multiple widths / zoom.

In Conclusion:

  • I like the solution.
  • I like the naming of the class.
  • I think the choice of which class in which location may need a bit more thought. And after that, some documentation or guidance for future use as to how to chose which shape to use.

@StephDriver StephDriver assigned joemull and unassigned StephDriver Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text becomes unreadable as when it scrolls over images at higher zoom levels

2 participants