Open
Conversation
StephDriver
requested changes
Feb 3, 2026
Member
There was a problem hiding this comment.
Testing and Observations
This looks great. I particularly like the naming of the classes using clock points.
- I can't find anything using
pointing-8-oclockI assume that is there for completeness?
Otherwise I've reviewed one of each of the class examples.
- I am unsure about the use of
pointing-10-oclockon theolh-awardtemplate - this looks odd with the triangle being parallel along one edge and almost but not along the other. For me this is jarring.
- Similarly, I am unsure about the angle used on the News page:
Great at this size:
But this is the 100% zoom version:
Contrast that with the Internships page, where the angle of the background works well at multiple widths / zoom.
In Conclusion:
- I like the solution.
- I like the naming of the class.
- I think the choice of which class in which location may need a bit more thought. And after that, some documentation or guidance for future use as to how to chose which shape to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242.
The strategy here is to create mostly invisible backgrounds that have the effect of erasing artwork that rolls behind text.
I went through all the custom templates to check for cases where this can happen and made changes. Here are some examples: