Open
Conversation
StephDriver
requested changes
Feb 3, 2026
Member
StephDriver
left a comment
There was a problem hiding this comment.
-
I like the svg solution - especially compared with the use of fonts on Janeway.
-
I think the spacing isn't quite right everywhere:
- I would like you to consider the readability impact of these icons. When adding similar to the Janeway front of house the text was cluttered, so I made them smaller, recede and in superscript so that they don't clutter the text as much. I'm not saying exactly the same is needed here, I offer this as a starting point for considering ways to keep the text readable.
opacity = 70%
vertical-align: super
font-size: 0.7em
versus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #306.
This strategy uses a JS script on all pages to apply the proper attributes and icon.
Why JS is needed
It's not possible to meet all the user requirements with CSS only, since we need to add the blank target attribute to user-generated content like news items, and we also want to check that urls do not include the current domain (there are sometimes hard-coded links to the openlibhums website that include the domain).
Screenshots