Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3943
Closes #3938
This PR introduces a new pattern for HTMX functionality in Janeway. There's a new
partial_views.pymodule specifically for HTMX endpoints, separate from regular views. Partial templates live in/appname/partials/. This keeps HTMX-specific code isolated rather than mixing it into existing views and templates, hopefully this will make it easier to find and maintain as we add more interactive features.Throughout the admin - article image management, journal settings, issue pages - there's now an "Edit alt text" button. Click it and you get an HTMX powered modal that lets you add or update alt text without page reloads. The modal itself is a reusable base template that other features can extend.