Skip to content

Feature to allow the submission url to be overridden for custom pages. #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RoseReatherford wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature to allow the submission url to be overridden for custom pages. #5113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/core/janeway_global_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,9 @@ def __len__(self):
HIJACK_USERS_ENABLED = False
HIJACK_LOGIN_REDIRECT_URL = "/manager/"

# Allows you to create your own submission page at `/start/submit` with the name `submission_start`.
HIJACK_SUBMISSION_ENABLED = False


# OIDC
ENABLE_OIDC = bool(os.environ.get("ENABLE_OIDC", False))
Expand Down
15 changes: 13 additions & 2 deletions src/submission/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@
__license__ = "AGPL v3"
__maintainer__ = "Birkbeck Centre for Technology and Publishing"
from django.urls import re_path
from django.conf import settings
from utils.logger import get_logger

from submission import views

logger = get_logger(__name__)

urlpatterns = [
re_path(r"^start/$", views.start, name="submission_start"),
re_path(r"^(?P<type>[-\w.]+)/start/$", views.start, name="submission_start"),
re_path(r"^(?P<article_id>\d+)/info/$", views.submit_info, name="submit_info"),
re_path(
r"^(?P<article_id>\d+)/authors/$", views.submit_authors, name="submit_authors"
Expand Down Expand Up @@ -108,3 +110,12 @@
name="submission_licenses_id",
),
]

if not settings.HIJACK_SUBMISSION_ENABLED:
try:
urlpatterns += [
re_path(r"^start/$", views.start, name="submission_start"),
re_path(r"^(?P<type>[-\w.]+)/start/$", views.start, name="submission_start"),
]
except AttributeError:
logger.warning("Could not import default submission views.")