Skip to content

Conversation

@EmanAbdelhaleem
Copy link
Contributor

@EmanAbdelhaleem EmanAbdelhaleem commented Jan 7, 2026

Depends on #1576
Related to #1575

Details

This PR implements Evaluations resource, and refactor its existing functions

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like circular imports

@geetu040 geetu040 mentioned this pull request Jan 9, 2026
25 tasks
@EmanAbdelhaleem
Copy link
Contributor Author

@geetu040 We have circular imports here cuz of importing OpenMLEvaluation

Error message:

  File "D:\Work\ESoC\Developing\openML\openml-python\scripts\reproduce_issues.py", line 1, in <module>
    import openml
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\__init__.py", line 21, in <module>
    from . import (
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\evaluations\__init__.py", line 3, in <module>
    from .evaluation import OpenMLEvaluation
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\evaluations\evaluation.py", line 7, in <module>
    import openml.runs
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\runs\__init__.py", line 3, in <module>
    from .functions import (
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\runs\functions.py", line 32, in <module>
    from openml.tasks import (
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\tasks\__init__.py", line 3, in <module>
    from .functions import (
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\tasks\functions.py", line 15, in <module>
    from openml._api import api_context
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\_api\__init__.py", line 1, in <module>
    from openml._api.runtime.core import APIContext
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\_api\runtime\core.py", line 10, in <module>
    from openml._api.resources import (
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\_api\resources\__init__.py", line 2, in <module>
    from openml._api.resources.evaluations import EvaluationsV1, EvaluationsV2
  File "D:\Work\ESoC\Developing\openML\openml-python\openml\_api\resources\evaluations.py", line 8, in <module>        
    from openml.evaluations.evaluation import OpenMLEvaluation
ImportError: cannot import name 'OpenMLEvaluation' from partially initialized module 'openml.evaluations.evaluation' (most likely due to a circular import) (D:\Work\ESoC\Developing\openML\openml-python\openml\evaluations\evaluation.py)```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants