Skip to content

Conversation

@adamfarquhar
Copy link
Contributor

Moved the pronom related modules to the pronom package as a basis for future refactoring. Created a utils package and added the char_handler and PerfTimer into it.

…t. Moved the pronom related modules to the pronom package as a basis for future refactoring.
@adamfarquhar adamfarquhar requested a review from Copilot November 13, 2024 17:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 11 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • fido/pronom/prepare.py: Evaluated as low risk
  • fido/fido.py: Evaluated as low risk
  • fido/pronom/update_signatures.py: Evaluated as low risk

… to use defusedxml rather than xml.etree. Also modifications in pronom.prepare to avoid using some python builtin identifiers like input, id, zip.
the Codacy review. The main was to use defusedxml
rather than xml.etree.  Also made modifications in
pronom.prepare to avoid using python builtin
identifiers input, id, zip.
the Codacy review. The main was to use defusedxml
rather than xml.etree.  Also made modifications in
pronom.prepare to avoid using python builtin
identifiers input, id, zip.
@adamfarquhar adamfarquhar marked this pull request as ready for review November 13, 2024 18:18
@adamfarquhar
Copy link
Contributor Author

Codacy static analysis seems to be out of tokens today, so does not complete.

@adamfarquhar adamfarquhar changed the title Consolidated pronom modules into pronom package and created a utils package Refactor: Consolidated pronom modules into pronom package and created a utils package Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants