-
-
Notifications
You must be signed in to change notification settings - Fork 5
Add support for db-ip.com
#99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #99 +/- ##
==========================================
+ Coverage 70.96% 71.42% +0.46%
==========================================
Files 4 4
Lines 465 476 +11
Branches 47 48 +1
==========================================
+ Hits 330 340 +10
Misses 117 117
- Partials 18 19 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sepandhaghighi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AHReccese
Thank you for your efforts. Please update the test_ipv4_functions.py file for this new API (network and timeout error cases)
sepandhaghighi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Reference Issues/PRs
#93
What does this implement/fix? Explain your changes.
Any other comments?