Refactor/naming #65
Merged
Refactor/naming #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHReccese
requested changes
Jan 22, 2025
Member
AHReccese
left a comment
AHReccese
left a comment
There was a problem hiding this comment.
Thank you for your effort.
Take a quick look on the TypeScript style guide.
src/Data/services.data.ts
Outdated
| import { ServiceName } from './constants.data'; | ||
|
|
||
| export const services_url = (url: string, subject?: string): { [key: string]: string } => { | ||
| export const serviceUrls = (url: string, subject?: string): { [key: string]: string } => { |
Collaborator
Author
There was a problem hiding this comment.
Since this constant is indeed a function (processes input and the result varies depending on the input), wouldn't it be better to use the lowerCamelCase style?
src/Data/services.data.ts
Outdated
| }; | ||
|
|
||
| export const Services = [ | ||
| export const services = [ |
Member
|
I'm fixing the issue with the failed GitHub action (it is up now as a separate pull request) after that I will review this PR. |
AHReccese
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Based on the conversation in #57 the refactoring is done.
Any other comments?