Skip to content

Conversation

@F-Shahali
Copy link
Collaborator

Reference Issues/PRs

#68

What does this implement/fix? Explain your changes.

Any other comments?

@F-Shahali F-Shahali added the bug Something isn't working label Mar 3, 2025
@F-Shahali F-Shahali added this to the mybutton v0.6 milestone Mar 3, 2025
@F-Shahali F-Shahali self-assigned this Mar 3, 2025
@F-Shahali F-Shahali modified the milestones: mybutton v0.6, mybutton v0.7 Mar 7, 2025
@F-Shahali F-Shahali requested a review from AHReccese March 25, 2025 18:23
@F-Shahali F-Shahali marked this pull request as ready for review March 25, 2025 18:23
Copy link
Member

@AHReccese AHReccese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain your changes briefly? I'm not getting them well just from the changes in the code.

@F-Shahali
Copy link
Collaborator Author

F-Shahali commented Mar 28, 2025

Could you please explain your changes briefly? I'm not getting them well just from the changes in the code.

Based on the link mentioned in the related issue (https://validator.w3.org/nu/?doc=https%3A%2F%2Fmybutton.click%2F), the changes involve removing trailing slashes from <meta> and <link> tags and ensuring that <script> tags are placed within the <head> or <body> sections.

@F-Shahali F-Shahali requested a review from AHReccese March 28, 2025 18:23
@AHReccese AHReccese merged commit 93c8fe7 into dev Apr 2, 2025
3 checks passed
@AHReccese AHReccese deleted the standard-html branch April 2, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants