Fix exception hierarchy #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where a new redhat OWNERS file is added but the chart doesn't contain the redhat- prefix, the workflow would fail without creating a comment for the user due to trying to download the Submission artifact. This artifact is missing (this is expected), because there was an issue during the parsing of the modified file in 'validate-submission'. This step should created a GitHub output 'submission_file_present'. This was not happening in that particular case due to 'ChartError' (exception raised when RedHat chart is missing the redhat- prefix) not being a SubmissionError exception. Fix openshift-helm-charts#465 Signed-off-by: Matthias Goerens <mgoerens@redhat.com>
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a new redhat OWNERS file is added but the chart doesn't contain the redhat- prefix, the workflow would fail without creating a comment for the user due to trying to download the Submission artifact.
This artifact is missing (this is expected), because there was an issue during the parsing of the modified file in 'validate-submission'. This step should created a GitHub output 'submission_file_present'. This was not happening in that particular case due to 'ChartError' (exception raised when RedHat chart is missing the redhat- prefix) not being a SubmissionError exception.
Fix #465