Skip to content

Conversation

@mgoerens
Copy link
Contributor

@mgoerens mgoerens commented Oct 24, 2025

Checks that the tarball contains a unique directory named after the chart. This directory must contain a Chart.yaml file. The directory may contain additional files or folders. No other files or folder should be placed at the root of the archive.

Fix #342

Running the check on all tarballs currently in the charts repo, I'm getting some (expected) errors with the redhat charts that were renamed:

❯ python check_tarfile_content.py -d tarball_dir/
Error with tarball redhat-data-grid-8.3.0.tgz: [ERROR] Incorrect tarball content: expected a redhat-data-grid directory
Error with tarball redhat-data-grid-8.3.1.tgz: [ERROR] Incorrect tarball content: expected a redhat-data-grid directory
Error with tarball redhat-data-grid-8.4.0.tgz: [ERROR] Incorrect tarball content: expected a redhat-data-grid directory
Error with tarball redhat-data-grid-8.4.2.tgz: [ERROR] Incorrect tarball content: expected a redhat-data-grid directory
Error with tarball redhat-data-grid-8.4.3.tgz: [ERROR] Incorrect tarball content: expected a redhat-data-grid directory
Error with tarball redhat-semeru-transition-1.0.0.tgz: [ERROR] Incorrect tarball content: expected a redhat-semeru-transition directory

For instance the redhat-data-grid-8.3.0.tgz tarball contains a data-grid directory instead. Newer versions of this chart contain valid tarball.

For redhat-semeru-transition-1.0.0.tgz, there is no newer version than 1.0.0

This was referenced Oct 24, 2025
@mgoerens mgoerens force-pushed the check_tarball_content branch 2 times, most recently from ea1f39f to 89f4513 Compare October 24, 2025 20:31
This was referenced Oct 24, 2025
This was referenced Oct 27, 2025
Copy link
Contributor

@jsm84 jsm84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete.

LGTM

@mgoerens mgoerens merged commit 63b62dd into openshift-helm-charts:main Oct 28, 2025
40 checks passed
@mgoerens mgoerens deleted the check_tarball_content branch October 28, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect tarball content is not detected

2 participants