-
Notifications
You must be signed in to change notification settings - Fork 17
Add check of tarball content #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mgoerens
merged 1 commit into
openshift-helm-charts:main
from
mgoerens:check_tarball_content
Oct 28, 2025
Merged
Add check of tarball content #471
mgoerens
merged 1 commit into
openshift-helm-charts:main
from
mgoerens:check_tarball_content
Oct 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2025
ea1f39f to
89f4513
Compare
This was referenced Oct 24, 2025
This was referenced Oct 27, 2025
jsm84
approved these changes
Oct 27, 2025
Contributor
jsm84
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that the tarball contains a unique directory named after the chart. This directory must contain a Chart.yaml file. The directory may contain additional files or folders. No other files or folder should be placed at the root of the archive.
Fix #342
Running the check on all tarballs currently in the charts repo, I'm getting some (expected) errors with the redhat charts that were renamed:
For instance the redhat-data-grid-8.3.0.tgz tarball contains a
data-griddirectory instead. Newer versions of this chart contain valid tarball.For redhat-semeru-transition-1.0.0.tgz, there is no newer version than 1.0.0