Fix error message for PRs with OWNERS and chart #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRs containing a chart and an OWNERS file were getting the wrong error message. This was due to the check for duplicate charts, not taking into account that an OWNERS file doens't relate to a specific version, and thus considering the OWNERS file to be for a different chart. Specific tests have been added to cover this case. Fix openshift-helm-charts#477 Signed-off-by: Matthias Goerens <mgoerens@redhat.com>
This was referenced Nov 6, 2025
Contributor
|
This is relatively small but I'll wait until next release to merge it to keep the fast-following release (pushing out token permission updates) tiny. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs containing a chart and an OWNERS file were getting the wrong error message. This was due to the check for duplicate charts, not taking into account that an OWNERS file doens't relate to a specific version, and thus considering the OWNERS file to be for a different chart.
Specific tests have been added to cover this case.
Fix #477