Skip to content

[main] Fix metadata-webhook cleanup race condition #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
openshift-cherrypick-robot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[main] Fix metadata-webhook cleanup race condition #3974

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02772e7
Limit metadata-webhook scope to serving-tests namespace
cardil Feb 7, 2026
217bf54
Fix metadata-webhook cleanup race condition
cardil Feb 9, 2026
db6ae8b
Add --ignore-not-found to namespace deletion
cardil Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions test/lib.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,16 @@ EOF
--upgradeopenshift
fi

# Delete the leftover namespace.
oc delete namespace serving-tests
# Delete metadata-webhook resources before deleting the namespace.
# This prevents blocking Route finalizer removal when webhook service is unavailable.
if [[ $MESH == "true" ]]; then
local rootdir
rootdir="$(dirname "$(dirname "$(realpath "${BASH_SOURCE[0]}")")")"
oc delete -f "${rootdir}/serving/metadata-webhook/config" --ignore-not-found
fi

# Delete the leftover namespace (may already be deleted by webhook config cleanup).
oc delete namespace serving-tests --ignore-not-found

logger.success 'Upgrade tests passed'
}
Expand Down
Loading