Skip to content

Conversation

@sebrandon1
Copy link

Similar to: openshift-kni/telco-reference#433

Changes:

  • Adds a quick PR check that attempts to kustomize build appropriate files. Only runs against main.
  • Adds a make path for make test-kustomize which runs the script. Users can run this locally as well as there are safeguards to ensure kustomize exists first.
  • Skips YAMLs that might require external plugins. See EXCLUDED_DIRS.

Example run:

$ make test-kustomize 
Checking all kustomization.yaml files can build successfully...

  ./deployment/kustomize/base: OK
  ./deployment/kustomize/overlays/default: OK
  ./deployment/kustomize/overlays/openshift: OK
  ./deployment/kustomize/overlays/openshift/rbac: OK

Summary: Checked 4 kustomization.yaml files
All kustomization files validated successfully!

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign tal-or for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebrandon1
Copy link
Author

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2025

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e ad5c7cb link true /test ci-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sebrandon1 sebrandon1 changed the title Add kustomize validation check CNFCERT-1258: Add kustomize validation check Jan 16, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2026

@sebrandon1: This pull request references CNFCERT-1258 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Similar to: openshift-kni/telco-reference#433

Changes:

  • Adds a quick PR check that attempts to kustomize build appropriate files. Only runs against main.
  • Adds a make path for make test-kustomize which runs the script. Users can run this locally as well as there are safeguards to ensure kustomize exists first.
  • Skips YAMLs that might require external plugins. See EXCLUDED_DIRS.

Example run:

$ make test-kustomize 
Checking all kustomization.yaml files can build successfully...

 ./deployment/kustomize/base: OK
 ./deployment/kustomize/overlays/default: OK
 ./deployment/kustomize/overlays/openshift: OK
 ./deployment/kustomize/overlays/openshift/rbac: OK

Summary: Checked 4 kustomization.yaml files
All kustomization files validated successfully!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants