-
Notifications
You must be signed in to change notification settings - Fork 51
[telco-core] Missing maxUnavailable: 100% in policy for upgrading all workers in a mcp #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alberto Losada <alosadag@redhat.com>
imiller0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update is good but needs additional context. See the comment added inline.
cc: @MarSik
Co-authored-by: Ian Miller <34246471+imiller0@users.noreply.github.com>
|
@alosadagrande: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
MarSik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alosadagrande, MarSik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We are missing the configuration to upgrade all workers of an MCP at the same time. I can confirm that by default it is upgrading one by one since the reference-cr/custom-manifests as it is stored in the repo is set to the default value of maxUnavailable: 1. Here
cc/ @imiller0