Skip to content

Conversation

@alosadagrande
Copy link
Contributor

@alosadagrande alosadagrande commented Oct 16, 2025

We are missing the configuration to upgrade all workers of an MCP at the same time. I can confirm that by default it is upgrading one by one since the reference-cr/custom-manifests as it is stored in the repo is set to the default value of maxUnavailable: 1. Here

cc/ @imiller0

Signed-off-by: Alberto Losada <alosadag@redhat.com>
@openshift-ci openshift-ci bot requested review from cgoncalves and ffromani October 16, 2025 14:30
@alosadagrande alosadagrande changed the title Adds missing maxUnavailable: 100% for upgrading all workers in a mcp [telco-core] Missing maxUnavailable: 100% in policy for upgrading all workers in a mcp Oct 16, 2025
Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update is good but needs additional context. See the comment added inline.
cc: @MarSik

Co-authored-by: Ian Miller <34246471+imiller0@users.noreply.github.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2025

@alosadagrande: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lintcheck 2e88844 link true /test lintcheck

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@MarSik MarSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alosadagrande, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants