-
Notifications
You must be signed in to change notification settings - Fork 583
Add configuration for coderabbit #2635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
📝 WalkthroughWalkthroughAdds a new Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Hello @JoelSpeed! Some important instructions when contributing to openshift/api: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
.coderabbit.yaml
🔇 Additional comments (2)
.coderabbit.yaml (2)
1-24: Configuration aligns well with PR objectives.The settings appropriately reduce noise by:
- Disabling high-level summaries, changed files summaries, sequence diagrams, and label suggestions (lines 4, 8–11).
- Collapsing the walkthrough into a collapsible section (line 7).
- Preferring local learnings for this repository (line 24).
- Explicitly using AGENTS.md for code guidelines (line 22).
- Excluding vendor and generated manifests from reviews (lines 13–17, pending fix above).
Once the two issues above are resolved, the configuration should effectively achieve the stated goals.
16-17: Path filter syntax error: missing negation prefix.Line 17 specifies
vendor/**without the!prefix. Unlike line 16 (!vendor/**), this will include vendor directories instead of excluding them, contradicting the PR objective to ignore vendor changes. Remove line 17 or correct it to match line 16.🔎 Proposed fix
- "!**/zz_generated.featuregated-crd-manifests/**" # Contains folders - - "!vendor/**" - - "vendor/**" + - "!vendor/**"Likely an incorrect or invalid review comment.
f2de708 to
dc5f7e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.coderabbit.yaml (1)
17-18: Consider removing redundant vendor pattern.Both
!**/vendor/**and!vendor/**are specified. The pattern!**/vendor/**matches vendor directories at any level (including the root), making!vendor/**redundant.🔎 Proposed simplification
- "!**/zz_generated.featuregated-crd-manifests/**" # Contains folders - "!**/vendor/**" - - "!vendor/**"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
.coderabbit.yaml
🔇 Additional comments (4)
.coderabbit.yaml (4)
1-1: LGTM!The language setting is correctly configured.
2-16: LGTM!The review configuration correctly disables unnecessary features to reduce noise as intended. All settings are valid according to the schema and align with the PR objectives.
19-21: LGTM!The golangci-lint tool is correctly enabled for Go code analysis.
22-28: LGTM!The knowledge base configuration correctly enables code guidelines from AGENTS.md and sets learnings scope to local, aligning with the PR objectives to use repository-specific guidelines and prefer local learnings.
yuqi-zhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm based on the documentation. A few fields (profile, review_status, commit_status) seem to be their default values. Did you mean to explicitly set those as well?
Yes. I was intending to be explicit about the choices rather than relying on defaults, even though these are the defaults |
|
/lgtm |
|
/approve |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Based on the configuration reference, this is an attempt to quieten coderabbit down to exactly the useful content we want.
This includes: