[DNM] alternate implementation of servicing abort for BMO #431

jacob-anders · 2025-09-09T11:17:59Z

No description provided.

jacob-anders · 2025-09-09T11:18:09Z

/hold

openshift-ci · 2025-09-09T11:18:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhjanders
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

internal/controller/metal3.io/baremetalhost_controller.go

internal/controller/metal3.io/host_state_machine.go

pkg/provisioner/ironic/servicing.go

This change addresses the issue of lack of clear pathway from recovering from a failed servicing operation. If serivcing operation is in progress or in the failed state and the user adjusts hfs.spec and/or hfc.spec (or removes the specs entirely) to ensure that ChangeDetected condition becomes false, servicing is aborted. Generated-By: Claude Code Sonnet 4 Signed-off-by: Jacob Anders <janders@redhat.com>

This change resolves the issue where removing hfc.spec results in ChangeDetected condition being set to True in case status.updates field is also present Assisted-By: Claude Code Sonnet 4 Signed-off-by: Jacob Anders <janders@redhat.com>

…e condition

openshift-ci · 2025-09-30T12:23:30Z

@rhjanders: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack	`a2078c3`	link	false	`/test e2e-metal-ipi-ovn-dualstack`
ci/prow/okd-scos-e2e-aws-ovn	`a2078c3`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jacob-anders · 2025-10-02T12:54:31Z

hmm this didn't quite work, uncommanded abort still occured:

grep abort[devscripts@u640-u04 dev-scripts]$ grep aborting bmo.log
{"level":"info","ts":1759401135.9130936,"logger":"provisioner.ironic","msg":"aborting servicing because no firmware changes detected","host":"openshift-machine-api~ostest-extraworker-1"}
{"level":"info","ts":1759401135.9131043,"logger":"provisioner.ironic","msg":"clearing maintenance flag before aborting servicing","host":"openshift-machine-api~ostest-extraworker-1"}
{"level":"info","ts":1759401140.9112108,"logger":"provisioner.ironic","msg":"aborting servicing because no firmware changes detected","host":"openshift-machine-api~ostest-extraworker-1"}
{"level":"info","ts":1759401140.9112153,"logger":"provisioner.ironic","msg":"aborting servicing due to removal of spec.updates/spec.settings","host":"openshift-machine-api~ostest-extraworker-1"}
[devscripts@u640-u04 dev-scripts]$

To be investigated further

openshift-bot · 2026-01-01T01:01:09Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2025

openshift-ci bot requested review from dtantsur and hroyrh September 9, 2025 11:18

jacob-anders force-pushed the servicing-backout-light branch 3 times, most recently from 59c1c10 to cf0df59 Compare September 11, 2025 05:41

jacob-anders force-pushed the servicing-backout-light branch 7 times, most recently from fad302d to bb35cb4 Compare September 22, 2025 06:32