OCPBUGS-67294: Require PreprovisioningImage for deprovisioning when cleaning is enabled #443
Conversation
When deprovisioning a host with automated cleaning enabled, BMO now: 1. Checks if a PreprovisioningImage is available before proceeding (in the provisioner's configureNode function) 2. Treats a PPI with a DeletionTimestamp as unavailable (in the controller's getPreprovImage function) Previously, the StateDeprovisioning case was not handled, and PPIs being deleted could still be used. This caused Ironic to fall back to building its own ISO and fail with a misleading "uefi_esp.img not found" error when the PPI was unavailable or being deleted. Assisted-By: Claude Sonnet 4.5 (commercial license) Signed-off-by: Riccardo Pittau <elfosardo@gmail.com> (cherry picked from commit c4631b5)
openshift-ci-robot
added
the
jira/valid-reference
|
@elfosardo: This pull request references Jira Issue OCPBUGS-67294, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
/cherry-pick release-4.20 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@elfosardo: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/okd-scos-images |
|
@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/okd-scos-images |
|
@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@elfosardo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/verified later @sgoveas |
openshift-ci-robot
added
verified-later
verified
|
@sgoveas: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
|
@elfosardo: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-merge-bot
bot
merged commit 2cf0e53
into
openshift:release-4.21
|
@elfosardo: Jira Issue OCPBUGS-67294: All pull requests linked via external trackers have merged: This pull request has the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@elfosardo: new pull request created: #446 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2026-01-21-020022 |
7 participants
When deprovisioning a host with automated cleaning enabled, BMO now:
Previously, the StateDeprovisioning case was not handled, and PPIs being deleted could still be used. This caused Ironic to fall back to building its own ISO and fail with a misleading "uefi_esp.img not found" error when the PPI was unavailable or being deleted.
Assisted-By: Claude Sonnet 4.5 (commercial license)
(cherry picked from commit c4631b5)