OCPBUGS-65571: Fix deletion hang when aborting inspection during power-off

[elfosardo]

When deleting a BMH during inspection, power-off could hang because:

1. After abort, node is in InspectFail with TargetProvisionState still
   set, blocking power changes
2. Ironic does not auto-clear TargetProvisionState in InspectFail state
3. PowerOff() misinterpreted the abort message in LastError as a
   power-off failure

Fix by:

• Explicitly transitioning from InspectFail to manageable to clear
  TargetProvisionState and allow power changes
• Ignoring "aborted" errors in LastError during power-off

[elfosardo]

/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [elfosardo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elfosardo]

/hold

[openshift-ci-robot]

@elfosardo: This pull request references Jira Issue OCPBUGS-65571, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sgoveas

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When deleting a BMH during inspection, power-off could hang because:

1. After abort, node is in InspectFail with TargetProvisionState still
   set, blocking power changes
2. PowerOff() misinterpreted the abort message in LastError as a
   power-off failure

Fix by:

• Handling InspectFail state in abortInspectionOrCleaning() to wait
  for TargetProvisionState to clear
• Ignoring "aborted" errors in LastError during power-off

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

I saw the unit test failing already before but it does not look related to this change

[elfosardo]

/retest

[openshift-ci]

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sgoveas]

/verified by sgoveas
pre-merge tested

[openshift-ci-robot]

@sgoveas: This PR has been marked as verified by sgoveas.

Details

In response to this:

/verified by sgoveas
pre-merge tested

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@elfosardo: This pull request references Jira Issue OCPBUGS-65571, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sgoveas

Details

In response to this:

When deleting a BMH during inspection, power-off could hang because:

1. After abort, node is in InspectFail with TargetProvisionState still
   set, blocking power changes
2. Ironic does not auto-clear TargetProvisionState in InspectFail state
3. PowerOff() misinterpreted the abort message in LastError as a
   power-off failure

Fix by:

• Explicitly transitioning from InspectFail to manageable to clear
  TargetProvisionState and allow power changes
• Ignoring "aborted" errors in LastError during power-off

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

/unhold

[jacob-anders]

/lgtm

[openshift-ci-robot]

@elfosardo: Jira Issue OCPBUGS-65571: All pull requests linked via external trackers have merged:

• openshift/baremetal-operator#438
• openshift/baremetal-operator#447

Jira Issue OCPBUGS-65571 has been moved to the MODIFIED state.

Details

In response to this:

When deleting a BMH during inspection, power-off could hang because:

1. After abort, node is in InspectFail with TargetProvisionState still
   set, blocking power changes
2. Ironic does not auto-clear TargetProvisionState in InspectFail state
3. PowerOff() misinterpreted the abort message in LastError as a
   power-off failure

Fix by:

• Explicitly transitioning from InspectFail to manageable to clear
  TargetProvisionState and allow power changes
• Ignoring "aborted" errors in LastError during power-off

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.