OCPBUGS-60218: PPC: ghw: filter out namespaces dir #1403

shajmakh · 2025-10-02T14:52:37Z

The previous code fails to run PPC when there is a namespace that has a
suffix nodes. ensure filtering the namespace directory to allow PPC to
work when such namespaces exist.

pkg/performanceprofile/profilecreator/mustgather.go

ffromani · 2025-10-02T15:16:26Z

pkg/performanceprofile/profilecreator/ghwhandler.go

 	nodeName := node.GetName()
 	nodePathSuffix := path.Join(nodes)
-	nodepath, err := getMustGatherFullPathsWithFilter(mustGatherDirPath, nodePathSuffix, clusterScopedResources)
+	nodepath, err := getMustGatherFullPathsWithFilter(mustGatherDirPath, nodePathSuffix, clusterScopedResources, namespaces)


so the core idea is to filter out clusterScopedResources and namespaces right?

correct. namespaces is affected by the user configuration so we should filter it out anyway

makes sense but need to review again why it causes issues (and why now)

sure, regarding "why now" it has always been the case but it is less common to have namespaces with "nodes" suffix. The bug has additional info.

openshift-ci-robot · 2025-10-03T09:26:06Z

@shajmakh: This pull request references Jira Issue OCPBUGS-60218, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The previous code fails to run PPC when there is a namespace that has a
suffix nodes. ensure filtering the namespace directory to allow PPC to
work when such namespaces exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ffromani

IIRC PPC doesn't care about the content in namespaces at all, and if so this change should be good. I want to verify that before approving. With this assumption, codewise LGTM

shajmakh · 2025-10-06T08:35:01Z

/jira refresh

openshift-ci-robot · 2025-10-06T08:35:08Z

@shajmakh: This pull request references Jira Issue OCPBUGS-60218, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

shajmakh · 2025-10-13T09:09:30Z

The failing lanes are not related to the PPC

shajmakh · 2025-10-13T09:10:19Z

/retest

ffromani

please remove from the change .idea/workspace.xml

ffromani

/approve

LGTM once the unnecessary file is removed

openshift-ci · 2025-10-27T11:04:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ffromani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ffromani · 2025-10-27T11:28:19Z

/hold

shajmakh · 2025-10-27T13:40:48Z

/approve

LGTM once the unnecessary file is removed

Thanks for the review. The file is removed.
/unhold

The consts are not used anywhere else so make them private. Signed-off-by: Shereen Haj <shajmakh@redhat.com>

The previous code fails to run PPC when there is a namespace that has a suffix `nodes`. ensure filtering the namespace directory to allow PPC to work when such namespaces exist. Signed-off-by: Shereen Haj <shajmakh@redhat.com>

ffromani

/lgtm

shajmakh · 2025-10-31T12:20:20Z

verified manually by me using the updated binary. Still this needs a QE confirmation post-merge:
/verified later @mrniranjan

openshift-ci-robot · 2025-10-31T12:20:32Z

@shajmakh: This PR has been marked to be verified later by @mrniranjan.

Details

In response to this:

verified manually by me using the updated binary. Still this needs a QE confirmation post-merge:
/verified later @mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

shajmakh · 2025-10-31T12:39:33Z

/cherry-pick release-4.20

openshift-cherrypick-robot · 2025-10-31T12:39:37Z

@shajmakh: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-10-31T16:02:41Z

/retest-required

Remaining retests: 0 against base HEAD bca7572 and 2 for PR HEAD 35c4645 in total

openshift-ci · 2025-10-31T18:45:23Z

@shajmakh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-10-31T18:49:00Z

@shajmakh: Jira Issue OCPBUGS-60218: All pull requests linked via external trackers have merged:

openshift/cluster-node-tuning-operator#1403

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-60218 has been moved to the MODIFIED state.

Details

In response to this:

The previous code fails to run PPC when there is a namespace that has a
suffix nodes. ensure filtering the namespace directory to allow PPC to
work when such namespaces exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-10-31T18:49:55Z

@shajmakh: new pull request created: #1421

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2025-11-04T03:57:11Z

Fix included in accepted release 4.21.0-0.nightly-2025-11-03-191704

openshift-ci bot requested review from Tal-or and ffromani October 2, 2025 14:53

ffromani reviewed Oct 2, 2025

View reviewed changes

pkg/performanceprofile/profilecreator/mustgather.go Outdated Show resolved Hide resolved

ffromani reviewed Oct 2, 2025

View reviewed changes

shajmakh force-pushed the ppc-mg-2025 branch from 1bfc65f to 0192a27 Compare October 3, 2025 09:24

shajmakh changed the title ~~PPC: ghw: filter out namespaces dir~~ OCPBUGS-60218: PPC: ghw: filter out namespaces dir Oct 3, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 3, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 3, 2025

ffromani reviewed Oct 3, 2025

View reviewed changes

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 6, 2025

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 6, 2025

ffromani reviewed Oct 27, 2025

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2025

shajmakh force-pushed the ppc-mg-2025 branch from 0192a27 to 35c4645 Compare October 27, 2025 13:38

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2025

shajmakh added 2 commits October 27, 2025 15:41

PPC: pkg: public consts to private

dcc17ff

The consts are not used anywhere else so make them private. Signed-off-by: Shereen Haj <shajmakh@redhat.com>

PPC: ghw: filter out namespaces dir

35c4645

The previous code fails to run PPC when there is a namespace that has a suffix `nodes`. ensure filtering the namespace directory to allow PPC to work when such namespaces exist. Signed-off-by: Shereen Haj <shajmakh@redhat.com>

ffromani reviewed Oct 27, 2025

View reviewed changes

openshift-ci bot assigned ffromani Oct 27, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2025

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Oct 31, 2025

openshift-merge-bot bot merged commit be65dc6 into openshift:main Oct 31, 2025
19 checks passed

openshift-cherrypick-robot mentioned this pull request Oct 31, 2025

[release-4.20] OCPBUGS-63751: PPC: ghw: filter out namespaces dir #1421

Open

OCPBUGS-60218: PPC: ghw: filter out namespaces dir #1403

OCPBUGS-60218: PPC: ghw: filter out namespaces dir #1403

Conversation

shajmakh commented Oct 2, 2025

Uh oh!

Uh oh!

ffromani Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

shajmakh Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

ffromani Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

shajmakh Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Oct 3, 2025

Uh oh!

ffromani left a comment

Choose a reason for hiding this comment

Uh oh!

shajmakh commented Oct 6, 2025

Uh oh!

openshift-ci-robot commented Oct 6, 2025

Uh oh!

shajmakh commented Oct 13, 2025

Uh oh!

shajmakh commented Oct 13, 2025

Uh oh!

ffromani left a comment

Choose a reason for hiding this comment

Uh oh!

ffromani left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Oct 27, 2025

Uh oh!

ffromani commented Oct 27, 2025

Uh oh!

shajmakh commented Oct 27, 2025

Uh oh!

ffromani left a comment

Choose a reason for hiding this comment

Uh oh!

shajmakh commented Oct 31, 2025

Uh oh!

openshift-ci-robot commented Oct 31, 2025

Uh oh!

shajmakh commented Oct 31, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 31, 2025

Uh oh!

openshift-ci-robot commented Oct 31, 2025

Uh oh!

openshift-ci bot commented Oct 31, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 31, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 31, 2025

Uh oh!

openshift-merge-robot commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants