OCPBUGS-62496: hypershift:e2e:status: check for duplicated configmap status #1413

Tal-or · 2025-10-16T10:10:18Z

Check that PerformanceProfile replacement doesn't add
additional configmap status.

This test is excersing the bug to avoid regressions in the future.

The fix filed for Hypershift repo: openshift/hypershift#7089

Signed-off-by: Talor Itzhak titzhak@redhat.com

openshift-ci-robot · 2025-10-16T10:10:27Z

@Tal-or: This pull request references Jira Issue OCPBUGS-62496, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

on hypershift platform,
when PerformanceProfile gets replaced with a new one,
there will be a short window when two different PerformanceProfile are exist for the same nodePool
until Hypershift operator catches up and deletes the old one.
in this case, we want to avoid creating duplicated ConfigMap for the status because it will
break Hypershift reconciliation loop:
https://github.com/openshift/hypershift/blob/53dc14cbdd1e46d8b648ed49c6419d34209ef406/hypershift-operator/controllers/nodepool/nto.go#L330

if a different ConfigMap for the status already exists, requeue the object for later.

Signed-off-by: Talor Itzhak titzhak@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Tal-or · 2025-10-16T15:17:29Z

/hold

Tal-or · 2025-10-19T08:02:37Z

/retest

Tal-or · 2025-10-21T07:50:19Z

/retest

When a PerformanceProfile is being replaced for a NodePool, hypershift controller lack the logic to delete the old profile from the HCP namespace. This commit resolve this gap. A dedicated e2e test coverage was added on NTO repo: openshift/cluster-node-tuning-operator#1413 Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Check that PerformanceProfile replacement doesn't add additional configmap status. This test is excersing the bug to avoid regressions in the future. Signed-off-by: Talor Itzhak <titzhak@redhat.com>

When a PerformanceProfile is being replaced for a NodePool, hypershift controller lack the logic to delete the old profile from the HCP namespace. This commit resolve this gap. A dedicated e2e test coverage was added on NTO repo: openshift/cluster-node-tuning-operator#1413 Signed-off-by: Talor Itzhak <titzhak@redhat.com>

openshift-ci-robot · 2025-10-23T09:21:05Z

@Tal-or: This pull request references Jira Issue OCPBUGS-62496, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Check that PerformanceProfile replacement doesn't add
additional configmap status.

This test is excersing the bug to avoid regressions in the future.

Signed-off-by: Talor Itzhak titzhak@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Tal-or · 2025-10-23T09:22:28Z

/hold
depends on: openshift/hypershift#7089
tested locally, with the above patch, the test is passing.

When a PerformanceProfile is being replaced for a NodePool, hypershift controller lack the logic to delete the old profile from the HCP namespace. This commit resolve this gap. A dedicated e2e test coverage was added on NTO repo: openshift/cluster-node-tuning-operator#1413 Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Tal-or · 2025-10-29T14:41:10Z

/hold cancel
/retest

openshift/hypershift#7089 got merged

Tal-or · 2025-10-30T09:38:30Z

/retest

When a PerformanceProfile is being replaced for a NodePool, hypershift controller lack the logic to delete the old profile from the HCP namespace. This commit resolve this gap. A dedicated e2e test coverage was added on NTO repo: openshift/cluster-node-tuning-operator#1413 Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Tal-or · 2025-11-04T12:32:46Z

/retest

Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Tal-or · 2025-11-05T08:49:33Z

/retest

openshift-ci · 2025-11-05T11:37:10Z

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

yanirq · 2025-12-10T09:58:40Z

/lgtm
/approve

yanirq · 2025-12-10T09:58:57Z

/cc @SargunNarula for verification

openshift-ci · 2025-12-10T09:59:02Z

@yanirq: GitHub didn't allow me to request PR reviews from the following users: for, verification.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @SargunNarula for verification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-12-10T09:59:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tal-or, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yanirq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Tal-or · 2025-12-10T17:03:21Z

/acknowledge-critical-fixes-only

Testing only, not affecting payload

openshift-bot · 2025-12-12T08:27:03Z

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

openshift-ci-robot · 2025-12-12T08:28:32Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-62496, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Tal-or · 2025-12-14T10:32:58Z

/jira refresh

openshift-ci-robot · 2025-12-14T10:33:04Z

@Tal-or: This pull request references Jira Issue OCPBUGS-62496, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Tal-or · 2025-12-14T10:40:30Z

/label acknowledge-critical-fixes-only

Testing only, not affecting payload and we already branched out anyway

yanirq · 2025-12-14T14:56:32Z

/cc @SargunNarula for verified label

openshift-ci · 2025-12-14T14:56:35Z

@yanirq: GitHub didn't allow me to request PR reviews from the following users: for, verified, label.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @SargunNarula for verified label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

SargunNarula · 2025-12-16T13:47:28Z

/verified by @SargunNarula

openshift-ci bot requested review from ffromani and yanirq October 16, 2025 10:10

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2025

Tal-or force-pushed the hcp_cm_status branch 3 times, most recently from ec3fe7f to b31802c Compare October 20, 2025 12:00

Tal-or force-pushed the hcp_cm_status branch from b31802c to b75deb5 Compare October 23, 2025 09:15

Tal-or changed the title ~~OCPBUGS-62496: hypershift:status: check for duplicated configmap status~~ OCPBUGS-62496: hypershift:status:e2e: check for duplicated configmap status Oct 23, 2025

Tal-or changed the title ~~OCPBUGS-62496: hypershift:status:e2e: check for duplicated configmap status~~ OCPBUGS-62496: hypershift:e2e:status: check for duplicated configmap status Oct 23, 2025

e2e: check PerformanceProfile replacement

45c1746

Check that PerformanceProfile replacement doesn't add additional configmap status. This test is excersing the bug to avoid regressions in the future. Signed-off-by: Talor Itzhak <titzhak@redhat.com>

Tal-or force-pushed the hcp_cm_status branch from b75deb5 to 45c1746 Compare October 23, 2025 09:17

Tal-or mentioned this pull request Oct 23, 2025

OCPBUGS-62496: fix: delete old profile during replacement openshift/hypershift#7089

Merged

2 tasks

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2025

makefile: filter hypershift tests from the non-hypershift lane

3e57d6d

Signed-off-by: Talor Itzhak <titzhak@redhat.com>

openshift-ci bot assigned yanirq Dec 10, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025

openshift-ci bot requested a review from SargunNarula December 10, 2025 09:59

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2025

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 12, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 14, 2025

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 14, 2025

OCPBUGS-62496: hypershift:e2e:status: check for duplicated configmap status #1413

Are you sure you want to change the base?

OCPBUGS-62496: hypershift:e2e:status: check for duplicated configmap status #1413

Conversation

Tal-or commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 16, 2025

Uh oh!

Tal-or commented Oct 16, 2025

Uh oh!

Tal-or commented Oct 19, 2025

Uh oh!

Tal-or commented Oct 21, 2025

Uh oh!

openshift-ci-robot commented Oct 23, 2025

Uh oh!

Tal-or commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tal-or commented Oct 29, 2025

Uh oh!

Tal-or commented Oct 30, 2025

Uh oh!

Tal-or commented Nov 4, 2025

Uh oh!

Tal-or commented Nov 5, 2025

Uh oh!

openshift-ci bot commented Nov 5, 2025

Uh oh!

yanirq commented Dec 10, 2025

Uh oh!

yanirq commented Dec 10, 2025

Uh oh!

openshift-ci bot commented Dec 10, 2025

Uh oh!

openshift-ci bot commented Dec 10, 2025

Uh oh!

Tal-or commented Dec 10, 2025

Uh oh!

openshift-bot commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

Tal-or commented Dec 14, 2025

Uh oh!

openshift-ci-robot commented Dec 14, 2025

Uh oh!

Tal-or commented Dec 14, 2025

Uh oh!

yanirq commented Dec 14, 2025

Uh oh!

openshift-ci bot commented Dec 14, 2025

Uh oh!

SargunNarula commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Tal-or commented Oct 16, 2025 •

edited

Loading

Tal-or commented Oct 23, 2025 •

edited

Loading

SargunNarula commented Dec 16, 2025 •

edited

Loading