Skip to content

OCPBUGS-63321: Watch MCP changes including spec and labels #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 18, 2025
Merged

OCPBUGS-63321: Watch MCP changes including spec and labels #1425

openshift-merge-bot merged 1 commit into from
Nov 18, 2025

Conversation

@MarSik
Copy link
Contributor

@MarSik MarSik commented Nov 6, 2025

MCP edits are properly watched by the runtime, but the predicate only reacted to changes in the MCP.status section. This meant we missed label and selector changes and never reconciled when those were changed.

@MarSik
OCPBUGS-63321: Watch MCP changes including spec and labels
c785f38 
MCP edits are properly watched by the runtime, but the predicate
only reacted to changes in the MCP.status section. This meant
we missed label and selector changes and never reconciled when
those were changed.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 6, 2025

@MarSik: This pull request references Jira Issue OCPBUGS-63321, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

MCP edits are properly watched by the runtime, but the predicate only reacted to changes in the MCP.status section. This meant we missed label and selector changes and never reconciled when those were changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MarSik
Copy link
Contributor Author

MarSik commented Nov 6, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 6, 2025

@MarSik: This pull request references Jira Issue OCPBUGS-63321, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mrniranjan November 6, 2025 12:30
Tal-or
Tal-or approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@Tal-or Tal-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Tal-or
Copy link
Contributor

Tal-or commented Nov 6, 2025 •
edited
Loading

I would add an integration/e2e test to avoid future regression

@openshift-ci openshift-ci bot requested review from swatisehgal and yanirq November 6, 2025 12:34
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@MarSik
Copy link
Contributor Author

MarSik commented Nov 7, 2025

/retest-required

@Tal-or
Copy link
Contributor

Tal-or commented Nov 9, 2025

/retest
Infra issues

@yanirq
Copy link
Contributor

yanirq commented Nov 10, 2025

/retest

@SargunNarula
Copy link
Contributor

SargunNarula commented Nov 14, 2025

/verified by @SargunNarula

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 14, 2025

@SargunNarula: This PR has been marked as verified by @SargunNarula.

Details

In response to this:

/verified by @SargunNarula

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 14, 2025

/retest-required

Remaining retests: 0 against base HEAD a3e9663 and 2 for PR HEAD c785f38 in total

@MarSik
Copy link
Contributor Author

MarSik commented Nov 18, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@MarSik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b7a53bc into openshift:main Nov 18, 2025
19 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2025

@MarSik: Jira Issue Verification Checks: Jira Issue OCPBUGS-63321
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63321 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

MCP edits are properly watched by the runtime, but the predicate only reacted to changes in the MCP.status section. This meant we missed label and selector changes and never reconciled when those were changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MarSik
Copy link
Contributor Author

MarSik commented Nov 19, 2025

/cherry-pick release-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 19, 2025

@MarSik: new pull request created: #1434

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 19, 2025
Open
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 23, 2025

Fix included in accepted release 4.21.0-0.nightly-2025-11-22-193140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrniranjan mrniranjan Awaiting requested review from mrniranjan

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

@yanirq yanirq Awaiting requested review from yanirq

1 more reviewer

@Tal-or Tal-or Tal-or approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tal-or Tal-or

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MarSik @openshift-ci-robot @Tal-or @yanirq @SargunNarula @openshift-cherrypick-robot @openshift-merge-robot