Skip to content

Conversation

@SargunNarula
Copy link
Contributor

This test verifies that housekeeping cpus gets updated on guaranteed QOS pods after node reboots.

@openshift-ci openshift-ci bot requested review from MarSik and swatisehgal December 4, 2025 11:31
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SargunNarula
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SargunNarula SargunNarula changed the title e2e: Added Irq test to verify housekeeping cpu updates with node reboot. e2e:Test to verify housekeeping cpu updates with node reboot. Dec 4, 2025
Signed-Off-by: Sargun Narula <snarula@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2025

@SargunNarula: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 60fb80a link true /test lint
ci/prow/e2e-upgrade 60fb80a link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

}
}

// PickNodeIdx selects a node index based on environment variable E2E_PAO_TARGET_NODE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this ?

isolatedCPUSet, err = cpuset.Parse(string(*profile.Spec.CPU.Isolated))
Expect(err).ToNot(HaveOccurred(), "failed to parse isolated CPUs")

targetNodeIdx := nodes.PickNodeIdx(workerRTNodes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to pick the target node ?, Why can' t it use worker-cnf node ?

initialProfile = profile.DeepCopy()
})

It("[test_id:99999] should update housekeeping CPUs when performance profile is modified", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a valid test case id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants