-
Notifications
You must be signed in to change notification settings - Fork 118
e2e:Test to verify housekeeping cpu updates with node reboot. #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SargunNarula The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-Off-by: Sargun Narula <snarula@redhat.com>
8eac8ab to
60fb80a
Compare
|
@SargunNarula: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| } | ||
| } | ||
|
|
||
| // PickNodeIdx selects a node index based on environment variable E2E_PAO_TARGET_NODE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this ?
| isolatedCPUSet, err = cpuset.Parse(string(*profile.Spec.CPU.Isolated)) | ||
| Expect(err).ToNot(HaveOccurred(), "failed to parse isolated CPUs") | ||
|
|
||
| targetNodeIdx := nodes.PickNodeIdx(workerRTNodes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to pick the target node ?, Why can' t it use worker-cnf node ?
| initialProfile = profile.DeepCopy() | ||
| }) | ||
|
|
||
| It("[test_id:99999] should update housekeeping CPUs when performance profile is modified", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a valid test case id
This test verifies that housekeeping cpus gets updated on guaranteed QOS pods after node reboots.