OCPBUGS-62632: Do not report Progressing=True during cluster scaleup or node reboot

[jmencak]

This change improves user's upgrade experience as outlined by OCPSTRAT-2484 by fixing false alarms in ClusterOperator status.

The following new rule is adhered to:

• Operators should not report Progressing only because DaemonSets owned by them are adjusting to a new node from cluster scaleup or a node rebooting from cluster upgrade.

This is achieved by adding helper annotation
tuned.openshift.io/stable-generation to the tuned daemonset.

Other minor fixes:

• Minor logging fix (updateTunedProfileStatus())
• Update profile.Status also when profile.Status.ObservedGeneration != profile.Generation
• Removed non-functional code from the operator initializing ClusterOperator status

Resolves: OCPBUGS-62632

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@jmencak: This pull request references Jira Issue OCPBUGS-62632, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This change improves user's upgrade experience as outlined by OCPSTRAT-2484 by fixing false alarms in ClusterOperator status.

The following new rule is adhered to:

• Operators should not report Progressing only because DaemonSets owned by them are adjusting to a new node from cluster scaleup or a node rebooting from cluster upgrade.

This is achieved by adding helper annotation
tuned.openshift.io/stable-generation to the tuned daemonset.

Other minor fixes:

• Minor logging fix (updateTunedProfileStatus())
• Update profile.Status also when profile.Status.ObservedGeneration != profile.Generation
• Removed non-functional code from the operator initializing ClusterOperator status

Resolves: OCPBUGS-62632

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jmencak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jmencak]

/jira refresh

[openshift-ci-robot]

@jmencak: This pull request references Jira Issue OCPBUGS-62632, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jmencak]

/test all

[jmencak]

/payload-job periodic-ci-openshift-release-master-ci-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade

[openshift-ci]

@jmencak: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-ci-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7bda56e0-d9b5-11f0-8a9c-d6494fa18d6f-0

[jmencak]

/test e2e-aws-ovn-techpreview

[jmencak]

@jmencak: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

* periodic-ci-openshift-release-master-ci-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7bda56e0-d9b5-11f0-8a9c-d6494fa18d6f-0

Upgrade test looks good, no legacy-cvo-invariants test issues from co/node-tuning.

[openshift-ci]

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.