CONSOLE-5029: Refactor withDashboardResources in with-dashboard-resources.tsx into …

[cajieh]

Summary

Removes the withDashboardResources Higher-Order Component in favor of targeted React hooks, modernizing 17 components across 10 files as part of the "Remove and Update Firehose" epic.

Problem

The withDashboardResources HOC injected all capabilities into every component regardless of actual needs:

• Performance: Unnecessary re-renders on unrelated data changes
• Clarity: Unclear dependencies per component
• Technical debt: Class-based HOC + Redux + Firehose coupling
• Type safety: Complex HOC intersection types

Solution

Replace monolithic HOC with targeted hooks based on actual usage:

Key Change: useDynamicDashboardResources

Bridges declarative hooks with imperative plugin requirements:
// Enables runtime resource watching without violating Rules of Hooks const { watchResource, stopWatchResource, results } = useDynamicDashboardResources();

  // Plugin extensions can register 0-N resources at runtime

  extensions.forEach((ext, i) => {
    watchResource(key(i), ext.properties.k8sResource);
  });

Benefits

• Performance: Components only watch what they need
• Code quality: -271 lines, clearer intent
• Type safety: Specific return types per hook
• Modern React: Hooks over HOCs, functional components

[openshift-ci-robot]

@cajieh: This pull request references CONSOLE-5031 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

NOT READY FOR READY

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [cajieh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cajieh]

Redundant!

[cajieh]

Redundant after the refactoring! The footer functionality is preserved with the same logic:
const shouldShowFooter = events?.loaded && events?.data && events.data.length > 50;

[openshift-ci-robot]

@cajieh: This pull request references CONSOLE-5031 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cajieh]

/retest

[openshift-ci-robot]

@cajieh: This pull request references CONSOLE-5029 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@cajieh: This pull request references CONSOLE-5029 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Removes the withDashboardResources Higher-Order Component in favor of targeted React hooks, modernizing 17 components across 10 files as part of the "Remove and Update Firehose" epic.

Problem

The withDashboardResources HOC injected all capabilities into every component regardless of actual needs:

Performance: Unnecessary re-renders on unrelated data changes
Clarity: Unclear dependencies per component
Technical debt: Class-based HOC + Redux + Firehose coupling
Type safety: Complex HOC intersection types

Solution

Replace monolithic HOC with targeted hooks based on actual usage:

Key Change: useDynamicDashboardResources

Bridges declarative hooks with imperative plugin requirements:
// Enables runtime resource watching without violating Rules of Hooks
const { watchResource, stopWatchResource, results } = useDynamicDashboardResources();

// Plugin extensions can register 0-N resources at runtime

 extensions.forEach((ext, i) => {
   watchResource(key(i), ext.properties.k8sResource);
 });

Benefits

Performance: Components only watch what they need
Code quality: -271 lines, clearer intent
Type safety: Specific return types per hook
Modern React: Hooks over HOCs, functional components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@cajieh: This pull request references CONSOLE-5029 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Removes the withDashboardResources Higher-Order Component in favor of targeted React hooks, modernizing 17 components across 10 files as part of the "Remove and Update Firehose" epic.

Problem

The withDashboardResources HOC injected all capabilities into every component regardless of actual needs:

• Performance: Unnecessary re-renders on unrelated data changes
• Clarity: Unclear dependencies per component
• Technical debt: Class-based HOC + Redux + Firehose coupling
• Type safety: Complex HOC intersection types

Solution

Replace monolithic HOC with targeted hooks based on actual usage:

Key Change: useDynamicDashboardResources

Bridges declarative hooks with imperative plugin requirements:
// Enables runtime resource watching without violating Rules of Hooks const { watchResource, stopWatchResource, results } = useDynamicDashboardResources();

 // Plugin extensions can register 0-N resources at runtime

 extensions.forEach((ext, i) => {
   watchResource(key(i), ext.properties.k8sResource);
 });

Benefits

• Performance: Components only watch what they need
• Code quality: -271 lines, clearer intent
• Type safety: Specific return types per hook
• Modern React: Hooks over HOCs, functional components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@cajieh: This pull request references CONSOLE-5029 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Removes the withDashboardResources Higher-Order Component in favor of targeted React hooks, modernizing 17 components across 10 files as part of the "Remove and Update Firehose" epic.

Problem

The withDashboardResources HOC injected all capabilities into every component regardless of actual needs:

• Performance: Unnecessary re-renders on unrelated data changes
• Clarity: Unclear dependencies per component
• Technical debt: Class-based HOC + Redux + Firehose coupling
• Type safety: Complex HOC intersection types

Solution

Replace monolithic HOC with targeted hooks based on actual usage:

Key Change: useDynamicDashboardResources

Bridges declarative hooks with imperative plugin requirements:
// Enables runtime resource watching without violating Rules of Hooks const { watchResource, stopWatchResource, results } = useDynamicDashboardResources();

 // Plugin extensions can register 0-N resources at runtime

 extensions.forEach((ext, i) => {
   watchResource(key(i), ext.properties.k8sResource);
 });

Benefits

• Performance: Components only watch what they need
• Code quality: -271 lines, clearer intent
• Type safety: Specific return types per hook
• Modern React: Hooks over HOCs, functional components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.