Skip to content

OCPBUGS-72260: '0 of pods' are shown in Status column on DaemonSets list page. #15928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cajieh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-72260: '0 of pods' are shown in Status column on DaemonSets list page. #15928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions frontend/public/components/workload-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,21 @@ const tableColumnInfo = [

export const ReplicasCount: React.FCC<ReplicasCountProps> = ({ obj, kind }) => {
const { t } = useTranslation();

// DaemonSets use different status fields than Deployments
const isDaemonSet = kind?.includes('DaemonSet');
const statusReplicas = isDaemonSet
? obj.status?.currentNumberScheduled ?? 0
: obj.status?.replicas ?? 0;
const specReplicas = isDaemonSet
? obj.status?.desiredNumberScheduled ?? 0
: obj.spec?.replicas ?? 0;

return (
<Link to={`${resourcePath(kind, obj.metadata.name, obj.metadata.namespace)}/pods`} title="pods">
{t('public~{{statusReplicas}} of {{specReplicas}} pods', {
statusReplicas: obj.status.replicas || 0,
specReplicas: obj.spec.replicas,
statusReplicas,
specReplicas,
})}
</Link>
);
Expand Down