Skip to content

NO-JIRA: Normalize generation of driver metrics RBAC proxy sidecar (extended) #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephenfin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-JIRA: Normalize generation of driver metrics RBAC proxy sidecar (extended) #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/common/sidecars/controller_driver_kube_rbac_proxy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ spec:
template:
spec:
containers:
- name: kube-rbac-proxy-${LOCAL_METRICS_PORT}
- name: driver-kube-rbac-proxy
securityContext:
readOnlyRootFilesystem: true
args:
Expand Down
2 changes: 1 addition & 1 deletion assets/common/sidecars/node_driver_kube_rbac_proxy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ spec:
template:
spec:
containers:
- name: kube-rbac-proxy-${LOCAL_METRICS_PORT}
- name: driver-kube-rbac-proxy
securityContext:
readOnlyRootFilesystem: true
args:
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/aws-ebs/generated/hypershift/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8201
name: driver-kube-rbac-proxy
ports:
- containerPort: 9201
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/aws-ebs/generated/standalone/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8201
name: driver-kube-rbac-proxy
ports:
- containerPort: 9201
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/azure-disk/generated/hypershift/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8201
name: driver-kube-rbac-proxy
ports:
- containerPort: 9201
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/azure-disk/generated/hypershift/node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8206
name: driver-kube-rbac-proxy
ports:
- containerPort: 9206
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/azure-disk/generated/standalone/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8201
name: driver-kube-rbac-proxy
ports:
- containerPort: 9201
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/azure-disk/generated/standalone/node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8206
name: driver-kube-rbac-proxy
ports:
- containerPort: 9206
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/azure-file/generated/hypershift/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8211
name: driver-kube-rbac-proxy
ports:
- containerPort: 9211
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/azure-file/generated/standalone/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8211
name: driver-kube-rbac-proxy
ports:
- containerPort: 9211
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/openstack-cinder/generated/hypershift/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8202
name: driver-kube-rbac-proxy
ports:
- containerPort: 9202
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/openstack-cinder/generated/standalone/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8202
name: driver-kube-rbac-proxy
ports:
- containerPort: 9202
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion assets/overlays/samba/generated/standalone/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8221
name: driver-kube-rbac-proxy
ports:
- containerPort: 9221
name: driver-m
Expand Down
2 changes: 1 addition & 1 deletion pkg/driver/common/operator/hooks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ func Test_WithHyperShiftControlPlaneImages(t *testing.T) {
expectedContainerImages: map[string]string{
"csi-driver": "control_plane_driver_image:1",
"csi-liveness-probe": "control_plane_livenessprobe_image:1",
"kube-rbac-proxy-8201": "control_plane_kube_rbac_proxy_image:1",
"driver-kube-rbac-proxy": "control_plane_kube_rbac_proxy_image:1",
"provisioner-kube-rbac-proxy": "control_plane_kube_rbac_proxy_image:1",
"attacher-kube-rbac-proxy": "control_plane_kube_rbac_proxy_image:1",
"resizer-kube-rbac-proxy": "control_plane_kube_rbac_proxy_image:1",
Expand Down
2 changes: 1 addition & 1 deletion pkg/driver/common/operator/test_manifests/aws_ebs_controller_hypershift.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ spec:
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy-8201
name: driver-kube-rbac-proxy
ports:
- containerPort: 9201
name: driver-m
Expand Down