Skip to content

Conversation

@jinyunma
Copy link
Contributor

The fix in https://issues.redhat.com//browse/OCPBUGS-62653 also needs to be applied in Azure UPI ARM template for UPI installation.

If you use blobs as source to create ACG Image versions:

    If you're using the old property ‘[properties.storageProfile.[osDiskImage/dataDiskImages].source.Id,‘](https://learn.microsoft.com/rest/api/compute/gallery-image-versions/create-or-update?view=rest-compute-2023-10-02&%253Btabs=HTTP&tabs=HTTP#gallerydiskimagesource) you should move to the property ’[properties.storageProfile.osDiskImage.source.storageAccountId’](https://learn.microsoft.com/rest/api/compute/gallery-image-versions/create-or-update?view=rest-compute-2023-10-02&%3Btabs=HTTP&tabs=HTTP#gallerydiskimagesource). This property requires minimum api-version 2022-03-03.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 10, 2025
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This pull request references Jira Issue OCPBUGS-64839, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The fix in https://issues.redhat.com//browse/OCPBUGS-62653 also needs to be applied in Azure UPI ARM template for UPI installation.

If you use blobs as source to create ACG Image versions:

   If you're using the old property ‘[properties.storageProfile.[osDiskImage/dataDiskImages].source.Id,‘](https://learn.microsoft.com/rest/api/compute/gallery-image-versions/create-or-update?view=rest-compute-2023-10-02&%253Btabs=HTTP&tabs=HTTP#gallerydiskimagesource) you should move to the property ’[properties.storageProfile.osDiskImage.source.storageAccountId’](https://learn.microsoft.com/rest/api/compute/gallery-image-versions/create-or-update?view=rest-compute-2023-10-02&%3Btabs=HTTP&tabs=HTTP#gallerydiskimagesource). This property requires minimum api-version 2022-03-03.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rna-afk and sadasu November 10, 2025 03:14
@jinyunma
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 10, 2025
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This pull request references Jira Issue OCPBUGS-64839, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@jinyunma: This pull request references Jira Issue OCPBUGS-64839, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jinyunma
Copy link
Contributor Author

/test e2e-azure-ovn-upi

@patrickdillon
Copy link
Contributor

I was just wondering whether we missed UPI. Thanks for taking care of this.

/approve
/lgtm
/test e2e-azure-ovn-upi

Strange, the upi job failed on worker provisioning.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2025
@jinyunma
Copy link
Contributor Author

Installation in e2e-azure-ovn-upi job passed this time, only few e2e test cases failed, should be unrelated with this PR.

And same change was also verified locally, installation succeeded.

/verified by jima

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 11, 2025
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This PR has been marked as verified by jima.

Details

In response to this:

Installation in e2e-azure-ovn-upi job passed this time, only few e2e test cases failed, should be unrelated with this PR.

And same change was also verified locally, installation succeeded.

/verified by jima

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jinyunma jinyunma changed the title OCPBUGS-64839: Azure UPI ARM tempalte: use storageAccountId OCPBUGS-64839: Azure UPI ARM template: use storageAccountId Nov 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

@jinyunma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack e9e3822 link false /test e2e-azurestack
ci/prow/e2e-azure-ovn-shared-vpc e9e3822 link false /test e2e-azure-ovn-shared-vpc
ci/prow/okd-scos-e2e-aws-ovn e9e3822 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azurestack-upi e9e3822 link false /test e2e-azurestack-upi
ci/prow/e2e-azure-ovn-upi e9e3822 link false /test e2e-azure-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6c16512 into openshift:main Nov 11, 2025
17 of 22 checks passed
@openshift-ci-robot
Copy link
Contributor

@jinyunma: Jira Issue Verification Checks: Jira Issue OCPBUGS-64839
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-64839 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

The fix in https://issues.redhat.com//browse/OCPBUGS-62653 also needs to be applied in Azure UPI ARM template for UPI installation.

If you use blobs as source to create ACG Image versions:

   If you're using the old property ‘[properties.storageProfile.[osDiskImage/dataDiskImages].source.Id,‘](https://learn.microsoft.com/rest/api/compute/gallery-image-versions/create-or-update?view=rest-compute-2023-10-02&%253Btabs=HTTP&tabs=HTTP#gallerydiskimagesource) you should move to the property ’[properties.storageProfile.osDiskImage.source.storageAccountId’](https://learn.microsoft.com/rest/api/compute/gallery-image-versions/create-or-update?view=rest-compute-2023-10-02&%3Btabs=HTTP&tabs=HTTP#gallerydiskimagesource). This property requires minimum api-version 2022-03-03.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jinyunma jinyunma deleted the OCPBUGS-64839-fix branch November 11, 2025 06:21
@jinyunma
Copy link
Contributor Author

/cherry-pick release-4.20

@openshift-cherrypick-robot

@jinyunma: new pull request created: #10069

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.21.0-0.nightly-2025-11-13-042845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants