-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CORS-4055: migrate EC2 API calls to AWS SDK v2 #10244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@tthvo: This pull request references CORS-4055 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @barbacbd @yunjiang29 |
|
/test e2e-aws-ovn-public-ipv4-pool e2e-aws-ovn-public-subnets e2e-aws-ovn-heterogeneous |
|
/label platform/aws |
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-fips-mini-perm-f14 |
|
@yunjiang29: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/788c71a0-f844-11f0-91e3-6f9960d4134a-0 |
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-byo-subnet-ovn-mini-perm-f14 |
|
@yunjiang29: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/917c9190-f844-11f0-92e7-f4ed54b9f812-0 |
barbacbd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
/retest-required |
|
/test e2e-aws-ovn-public-ipv4-pool e2e-aws-ovn-public-subnets |
The commit is an incremental step to migrate AWS API calls to AWS SDK v2. This focuses on EC2 clients in the pkg/asset and dependent pkg(s).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barbacbd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-byo-subnet-ovn-mini-perm-f14 |
|
@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/56e29a70-fbe1-11f0-8469-3c3ba4209811-0 |
|
@tthvo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This focuses on EC2 clients in the
pkg/assetand dependent pkg(s). To check if any AWS SDK v1, we can run:Notes:
instancetypes.gofile will be migrated to AWS SDK v2 in #10238 as part of dual-stack work. Depending on the merge order, one mustgo mod tidyto remove unused AWS SDK v1 EC2 dependencies.