Skip to content

Conversation

@tthvo
Copy link
Member

@tthvo tthvo commented Jan 22, 2026

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This focuses on IAM clients in the pkg/asset and dependent pkg(s). To check if any AWS SDK v1, we can run:

$ grep -InHr '"github.com/aws/aws-sdk-go/service/iam"' "pkg" --color=always --exclude-dir={vendor}
pkg/destroy/aws/aws.go:18:	"github.com/aws/aws-sdk-go/service/iam"
pkg/destroy/aws/ec2helpers.go:16:	"github.com/aws/aws-sdk-go/service/iam"
pkg/destroy/aws/iamhelpers.go:11:	"github.com/aws/aws-sdk-go/service/iam"
pkg/destroy/aws/shared.go:14:	"github.com/aws/aws-sdk-go/service/iam"

Notes: References in the destroy code will be migrated to AWS SDK v2 in #9982.

The commit is an incremental step to migrate AWS API calls to AWS SDK
v2. This focuses on IAM clients in the pkg/asset and dependent pkg(s).
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 22, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2026

@tthvo: This pull request references CORS-4055 which is a valid jira issue.

Details

In response to this:

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This focuses on IAM clients in the pkg/asset and dependent pkg(s). To check if any AWS SDK v1, we can run:

$ grep -InHr '"github.com/aws/aws-sdk-go/service/iam"' "pkg" --color=always --exclude-dir={vendor}
pkg/destroy/aws/aws.go:18:	"github.com/aws/aws-sdk-go/service/iam"
pkg/destroy/aws/ec2helpers.go:16:	"github.com/aws/aws-sdk-go/service/iam"
pkg/destroy/aws/iamhelpers.go:11:	"github.com/aws/aws-sdk-go/service/iam"
pkg/destroy/aws/shared.go:14:	"github.com/aws/aws-sdk-go/service/iam"

Notes: References in the destroy code will be migrated to AWS SDK v2 in #9982.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member Author

tthvo commented Jan 22, 2026

/test e2e-aws-ovn-custom-iam-profile

@tthvo
Copy link
Member Author

tthvo commented Jan 22, 2026

/label platform/aws
/cc @barbacbd @yunjiang29

We need to wait for #9982 to merge first. Then, we'll need to go mod tidy here to remove the used SDK v1 deps :D

@yunjiang29
Copy link
Contributor

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-aws-ipi-byo-iam-profile-mini-perm-arm-f7

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@yunjiang29: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-aws-ipi-byo-iam-profile-mini-perm-arm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/119a12e0-f844-11f0-8a3b-c8d3bacf713a-0

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@barbacbd
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2026
@yunjiang29
Copy link
Contributor

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-aws-ipi-byo-iam-profile-mini-perm-arm-f7

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

@yunjiang29: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-aws-ipi-byo-iam-profile-mini-perm-arm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8e446d60-fb2b-11f0-869f-357234b3f4bc-0

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026
@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-heterogeneous 352241d link false /test e2e-aws-ovn-heterogeneous
ci/prow/e2e-aws-ovn-single-node 352241d link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones 352241d link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-aws-ovn-edge-zones 352241d link false /test e2e-aws-ovn-edge-zones

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. platform/aws

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants