Skip to content

AGENT-1431: Backport feature NoRegistryClusterInstall to 4.21 #10250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pawanpinjarkar wants to merge 2 commits into
base: release-4.21
Choose a base branch
from
Open

AGENT-1431: Backport feature NoRegistryClusterInstall to 4.21 #10250

pawanpinjarkar wants to merge 2 commits into from
+26 −4

Conversation

@pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented Jan 23, 2026

This is a manual cherry-pick of below stories:
https://issues.redhat.com/browse/AGENT-1425 Local assisted UI url not shown in the terminal console PR #10237
https://issues.redhat.com/browse/AGENT-1309: Modify NoRegistryClusterInstall storage requirements PR #10176

@pawanpinjarkar
AGENT-1309: Modify OVE storage requirements
e5b1150
@pawanpinjarkar
AGENT-1425: TUI does not show local web UI URL
fc464bc 
The agent-ui service was previously updated to 'Type=notify' to improve startup ordering and reliability.
However, the lack of container monitor '--sdnotify=conmon' flag, resulted in UI URL to be not displayed on the TUI.
Without this flag, agent-ui systemd waits for a readiness signal which never comes and the service remains in 'activating' state.
This causes the TUI availability check to fail, making the user only see "Waiting for services" instead of UI URL
( even though the UI is already avaialble via the usual URL)

This commit adds the missing flag, ensuring the notification handshake between the container running UI and the agent-ui systemd completes successfully and unblocking the TUI. This commit also fixes the stale dependency in agent-register-infraenv related to agent-ui systemd naming.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 23, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2026 •
edited by openshift-ci bot
Loading

@pawanpinjarkar: This pull request references AGENT-1431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This is a manual cherry-pick of below stories:
https://issues.redhat.com/browse/AGENT-1425 Local assisted UI url not shown in the terminal console PR #10237
https://issues.redhat.com/browse/AGENT-1309: Modify NoRegistryClusterInstall storage requirements PR #10176

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano
Copy link
Contributor

andfasano commented Jan 23, 2026

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2026
@openshift-ci openshift-ci bot requested review from rwsu and zaneb January 23, 2026 15:17
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawanpinjarkar pawanpinjarkar changed the title AGENT-1431: Cherrypick AGENT-1309 and AGENT-1425 AGENT-1431: Backport feature NoRegistryClusterInstall to 4.21 Jan 23, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-two-node-fencing-ipv4 fc464bc link false /test e2e-agent-two-node-fencing-ipv4
ci/prow/e2e-agent-compact-ipv4-iso-no-registry fc464bc link false /test e2e-agent-compact-ipv4-iso-no-registry
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage fc464bc link false /test e2e-agent-compact-ipv4-appliance-diskimage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwsu rwsu Awaiting requested review from rwsu

@zaneb zaneb Awaiting requested review from zaneb

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawanpinjarkar @openshift-ci-robot @andfasano